Closed Bug 511476 Opened 10 years ago Closed 10 years ago

calendar-event-dialog-freebusy.xml: Remove obsolete range check

Categories

(Calendar :: Dialogs, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martinschroeder, Assigned: martinschroeder)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Follow-up from bug 421329#c14: Remove obsolete range check.

if (rangeStart.compare(start) >= 0 &&
    rangeEnd.compare(end) <= 0) {
Attachment #395365 - Flags: review?(philipp)
Comment on attachment 395365 [details] [diff] [review]
Patch v1

>+                          let minute = Math.floor(
>+                              value % minutes_per_day) -
I'd opt for putting this in one line, even if it goes over 80 chars.

>+                          if (minute >= (numHours * 60)) {
>+                              minute = (numHours * 60) - 1;
>+                          }
Can't you just use Math.max here?

r=philipp, above nits optional.
Attachment #395365 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/46da3d7f7715>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.