511476 - calendar-event-dialog-freebusy.xml: Remove obsolete range check

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Follow-up from bug 421329#c14: Remove obsolete range check.

if (rangeStart.compare(start) >= 0 &&
    rangeEnd.compare(end) <= 0) {

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 395365 [details] [diff] [review]
Patch v1

>+                          let minute = Math.floor(
>+                              value % minutes_per_day) -
I'd opt for putting this in one line, even if it goes over 80 chars.

>+                          if (minute >= (numHours * 60)) {
>+                              minute = (numHours * 60) - 1;
>+                          }
Can't you just use Math.max here?

r=philipp, above nits optional.

Comment 2

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/46da3d7f7715>

-> FIXED