511576 - pkix_getDecodeFunction may fail to load libsmime3

Status: NEW

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

The following code is not complete.
It should try to load libsmime3 by absolute path, not simple filename. Otherwise, there may be failures on systems where PATH or LD_LIBRARY_PATH is not set, and if the application itself hasn't already loaded libsmime3.

See lib/freebl/genload.c for the way to load with the absolute path.

static PRStatus PR_CALLBACK pkix_getDecodeFunction(void)
{
    pkix_decodeFunc.smimeLib = 
		PR_LoadLibrary(SHLIB_PREFIX"smime3."SHLIB_SUFFIX);
    if (pkix_decodeFunc.smimeLib == NULL) {
	return PR_FAILURE;
    }

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Alexei, Julien and I should discuss this together. 
I think our advice on this subject is changing over time, and we should
be careful to have and use a consistent answer throughout NSS, as much as
we can (as FIPS will allow)

Comment 2

[Julien Pierre]

Nelson,

Re: comment 1,
The code in question is in libpkix. What's the relevance of FIPS here ?

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Our ability to change the way that NSS loads shared libraries consistently
in all parts of NSS at this time is limited by our self-imposed freeze on 
the FIPS code.  That's all.

Comment 4

[Julien Pierre]

Bob and I are in agreement that the code from genload.c should be moved out of freebl and to nssutil3. All code in NSS should be using that copy from now on, including this libpkix code.

softoken/freebl probably won't change over to using the new copy until 3.13 .

Comment 5

[Julien Pierre]

Adding dependency on bug 511312 since we should use the new copy of genload.c in nssutil.

Comment 6

[Julien Pierre]

Attachment: Use PORT_LoadLibraryFromOrigin

This patch will use the new shared loader function from bug 511312 .

Comment 7

[Wan-Teh Chang]

Comment on attachment 397405 [details] [diff] [review]
Use PORT_LoadLibraryFromOrigin

r=wtc.

>-		PR_LoadLibrary(SHLIB_PREFIX"smime3."SHLIB_SUFFIX);
>+		PORT_LoadLibraryFromOrigin(SHLIB_PREFIX"nss3."SHLIB_SUFFIX,
>+                                           (PRFuncPtr)&pkix_getDecodeFunction,
>+                                           SHLIB_PREFIX"smime3."SHLIB_SUFFIX);

It seems to look nicer to have the library we want to load
(libsmime3) as the first argument...

Comment 8

[Kai Engert [:KaiE:]]

Bugs that are currently assigned to Julien => assigning to nobody.
Search for 20100628-kaie-jp