Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

({verified1.9.1})

Trunk
x86
All
verified1.9.1
Points:
---
Dependency tree / graph
Bug Flags:
wanted1.9.0.x -

Firefox Tracking Flags

(status1.9.2 beta1-fixed, blocking1.9.1 .4+, status1.9.1 .4-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Update libfishsound to upstream current git HEAD.
(Assignee)

Updated

9 years ago
Blocks: 512327
(Assignee)

Comment 1

9 years ago
Created attachment 397087 [details] [diff] [review]
Patch 

Update libfishsound to 20609d34c41fa.
Attachment #397087 - Flags: review?(chris.double)

Updated

9 years ago
Attachment #397087 - Flags: review?(chris.double) → review+
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

9 years ago
Comment on attachment 397087 [details] [diff] [review]
Patch 

This is supposed to be required by bug 512328, its the upstream commit logs say that they require the this fishsound update. Bug 512328 landed on 1.9.2, but I forgot to land this one, so we should land this on 1.9.2 as well.
Attachment #397087 - Flags: approval1.9.2?
(Assignee)

Comment 4

9 years ago
Comment on attachment 397087 [details] [diff] [review]
Patch 

Requesting approval for this on 1.9.1 as well.
We should have this patch everywhere we have the patch for bug 512328, which people want on 1.9.1. So we need this on 1.9.1 as well.
Attachment #397087 - Flags: approval1.9.1.4?
Comment on attachment 397087 [details] [diff] [review]
Patch 

a192=beltzner
Attachment #397087 - Flags: approval1.9.2? → approval1.9.2+
Comment on attachment 397087 [details] [diff] [review]
Patch 

Approved for 1.9.1.4, a=dveditz
Attachment #397087 - Flags: approval1.9.1.4? → approval1.9.1.4+
blocking1.9.1: --- → .4+
status1.9.1: --- → wanted
Flags: wanted1.9.0.x-
(Assignee)

Comment 8

9 years ago
Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a8572eafe369
status1.9.1: wanted → .4-fixed
cpearce, how can QA test libfishsound?  can you provide some front end testcases on what to expect?   Thanks.

Comment 10

9 years ago
Play any Ogg file with sound. If file plays and the sound is audible, libfishsound is working.
Verified for 1.9.1 with wonderful ogg music at http://commons.wikimedia.org/wiki/File:12-04-2005-2400.ogg with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4pre) Gecko/20090930 Shiretoko/3.5.4pre.
Keywords: verified1.9.1
status1.9.2: --- → beta1-fixed
Blocks: 468293
You need to log in before you can comment on or make changes to this bug.