Closed
Bug 511584
Opened 15 years ago
Closed 15 years ago
Update libfishsound
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
blocking1.9.1 | --- | .4+ |
status1.9.1 | --- | .4-fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
27.68 KB,
patch
|
cajbir
:
review+
beltzner
:
approval1.9.2+
dveditz
:
approval1.9.1.4+
|
Details | Diff | Splinter Review |
Update libfishsound to upstream current git HEAD.
Assignee | ||
Updated•15 years ago
|
Blocks: CVE-2009-3377
Assignee | ||
Comment 1•15 years ago
|
||
Update libfishsound to 20609d34c41fa.
Attachment #397087 -
Flags: review?(chris.double)
Updated•15 years ago
|
Attachment #397087 -
Flags: review?(chris.double) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/2db5b995c28f
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 397087 [details] [diff] [review]
Patch
This is supposed to be required by bug 512328, its the upstream commit logs say that they require the this fishsound update. Bug 512328 landed on 1.9.2, but I forgot to land this one, so we should land this on 1.9.2 as well.
Attachment #397087 -
Flags: approval1.9.2?
Assignee | ||
Comment 4•15 years ago
|
||
Comment on attachment 397087 [details] [diff] [review]
Patch
Requesting approval for this on 1.9.1 as well.
We should have this patch everywhere we have the patch for bug 512328, which people want on 1.9.1. So we need this on 1.9.1 as well.
Attachment #397087 -
Flags: approval1.9.1.4?
Comment 5•15 years ago
|
||
Comment on attachment 397087 [details] [diff] [review]
Patch
a192=beltzner
Attachment #397087 -
Flags: approval1.9.2? → approval1.9.2+
Comment 6•15 years ago
|
||
Comment on attachment 397087 [details] [diff] [review]
Patch
Approved for 1.9.1.4, a=dveditz
Attachment #397087 -
Flags: approval1.9.1.4? → approval1.9.1.4+
Updated•15 years ago
|
Assignee | ||
Comment 7•15 years ago
|
||
Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4e626ba52d2a
Assignee | ||
Comment 8•15 years ago
|
||
Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a8572eafe369
Comment 9•15 years ago
|
||
cpearce, how can QA test libfishsound? can you provide some front end testcases on what to expect? Thanks.
Comment 10•15 years ago
|
||
Play any Ogg file with sound. If file plays and the sound is audible, libfishsound is working.
Comment 11•15 years ago
|
||
Verified for 1.9.1 with wonderful ogg music at http://commons.wikimedia.org/wiki/File:12-04-2005-2400.ogg with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4pre) Gecko/20090930 Shiretoko/3.5.4pre.
Keywords: verified1.9.1
Updated•15 years ago
|
status1.9.2:
--- → beta1-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•