Closed Bug 511584 Opened 13 years ago Closed 13 years ago

Update libfishsound

Categories

(Core :: Audio/Video, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed
blocking1.9.1 --- .4+
status1.9.1 --- .4-fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

Update libfishsound to upstream current git HEAD.
Attached patch Patch Splinter Review
Update libfishsound to 20609d34c41fa.
Attachment #397087 - Flags: review?(chris.double)
Attachment #397087 - Flags: review?(chris.double) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 397087 [details] [diff] [review]
Patch 

This is supposed to be required by bug 512328, its the upstream commit logs say that they require the this fishsound update. Bug 512328 landed on 1.9.2, but I forgot to land this one, so we should land this on 1.9.2 as well.
Attachment #397087 - Flags: approval1.9.2?
Comment on attachment 397087 [details] [diff] [review]
Patch 

Requesting approval for this on 1.9.1 as well.
We should have this patch everywhere we have the patch for bug 512328, which people want on 1.9.1. So we need this on 1.9.1 as well.
Attachment #397087 - Flags: approval1.9.1.4?
Comment on attachment 397087 [details] [diff] [review]
Patch 

a192=beltzner
Attachment #397087 - Flags: approval1.9.2? → approval1.9.2+
Comment on attachment 397087 [details] [diff] [review]
Patch 

Approved for 1.9.1.4, a=dveditz
Attachment #397087 - Flags: approval1.9.1.4? → approval1.9.1.4+
blocking1.9.1: --- → .4+
Flags: wanted1.9.0.x-
cpearce, how can QA test libfishsound?  can you provide some front end testcases on what to expect?   Thanks.
Play any Ogg file with sound. If file plays and the sound is audible, libfishsound is working.
Verified for 1.9.1 with wonderful ogg music at http://commons.wikimedia.org/wiki/File:12-04-2005-2400.ogg with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.4pre) Gecko/20090930 Shiretoko/3.5.4pre.
Keywords: verified1.9.1
Blocks: 468293
You need to log in before you can comment on or make changes to this bug.