511635 - Port Bug 455070 [Make sessionStorage object conform the WHATWG spec] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch for 1.9.1 branch

From parent bug:

that is:
- change the getItem method to return DOMString (use nsIDOMStorage2 interface
for the storage)
- change mapping of session storage by an origin and not by a domain as it is
now
- compare principals instead of just string origins on some places

Attached patch for 1.9.1 branch, my bugzilla knowledge don't allow me to set proper flags to indicate that additional patch will be needed when we change to another branch.

Comment 1

[Misak Khachatryan]

Attachment: universal patch

OK, this one uses #ifdef MOZILLA_1_9_1_BRANCH, and it's universal.

Comment 2

[[e-mail]]

Comment on attachment 400483 [details] [diff] [review]
universal patch

>+#ifdef MOZILLA_1_9_1_BRANCH
>+        let docShell_191 = aDocShell.QueryInterface(Components.interfaces.nsIDocShell_MOZILLA_1_9_1_SessionStorage);
>+        storage = docShell_191.getSessionStorageForURI(uri);
>+#else
>         storage = aDocShell.getSessionStorageForURI(uri);
>+#endif
Just use aDocShell.QueryInterface(Components.interfaces.nsIDocShell_MOZILLA_1_9_1_SessionStorage);
Compare attachment 379532 [details] [diff] [review].

Comment 3

[Misak Khachatryan]

Attachment: fixed patch

Comment 4

[Misak Khachatryan]

Attachment: proper fix

Sorry, now i understand what you mean.

Comment 5

[Misak Khachatryan]

Attachment: combined patch with fix for bug 511823

As Neil suggested, uploading combined patch with fix for bug 511823.

Comment 6

[[e-mail]]

Comment on attachment 400733 [details] [diff] [review]
combined patch with fix for bug 511823

>     let ioService = Components.classes["@mozilla.org/network/io-service;1"].getService(Components.interfaces.nsIIOService);
>+#ifdef MOZILLA_1_9_1_BRANCH
>+      aDocShell.QueryInterface(Components.interfaces.nsIDocShell_MOZILLA_1_9_1_SessionStorage);
>+#endif
>     for (let url in aStorageData) {
Nit: indentation of aDocShell.QueryInterface is wrong.

Comment 7

[Misak Khachatryan]

Attachment: for checkin [Checkin: Comment 9]

nit fixed, for checkin

Comment 8

[Misak Khachatryan]

sorry, forgot to add carrying forward r+ and sr+ from Neil

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 400739 [details] [diff] [review]
for checkin
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/3eb3ed8481ed