Closed Bug 511640 Opened 11 years ago Closed 11 years ago

Port Bug 490040 [Reattaching a lone tab into another window causes an empty window to be added to Recently Closed Windows]

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b2

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Description from parent bug: 

STR:
0. Look at Recently Closed Windows menu
1. Open 2 windows (A & B). Make sure window B only has one tab.
2. Drag the lone tab from window B to window A
3. Recently Closed Windows now has a menu entry for (Untitled).

Expected Behavior:
No new entry is added to the menu.

Proposed Solution:
One possibility is to just ignore empty windows in session store, though this
could possibly cause issues with the win/linux need for a non-popup window.
Attachment #395585 - Flags: superreview?(neil)
Attachment #395585 - Flags: review?(neil)
Comment on attachment 395585 [details] [diff] [review]
patch

We can't actually switch tabs between windows yet but that's no excuse ;-)
Attachment #395585 - Flags: superreview?(neil)
Attachment #395585 - Flags: superreview+
Attachment #395585 - Flags: review?(neil)
Attachment #395585 - Flags: review+
Keywords: checkin-needed
Comment on attachment 395585 [details] [diff] [review]
patch


{
patching file suite/common/src/nsSessionStore.js
Hunk #2 FAILED at 528
1 out of 2 hunks FAILED
}
and I don't have a clue where the patch context comes from :-<
Attachment #395585 - Attachment is obsolete: true
Depends on: 510890
Comment on attachment 395585 [details] [diff] [review]
patch

I'm sorry for not stating this clear before, this patch should be applied after bug 510890, which is ready to land BTW.
Attachment #395585 - Attachment is obsolete: false
Keywords: checkin-needed
Whiteboard: checkin - see comment #3
Pushed as http://hg.mozilla.org/comm-central/rev/0a8d10dcc759

Misak, feel free to resolve this bug if everything here is fixed! :)
Keywords: checkin-needed
Whiteboard: checkin - see comment #3
Target Milestone: --- → seamonkey2.0b2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.0b2 → ---
Target Milestone: --- → seamonkey2.0b2
I accidentally pushed http://hg.mozilla.org/comm-central/rev/058aa5379fc7 with a comment pointing to this bug here, but it was actually for bug 510890. Just as a note if anyone follows this patch back to its origin.
You need to log in before you can comment on or make changes to this bug.