511640 - Port Bug 490040 [Reattaching a lone tab into another window causes an empty window to be added to Recently Closed Windows]

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

Description from parent bug: 

STR:
0. Look at Recently Closed Windows menu
1. Open 2 windows (A & B). Make sure window B only has one tab.
2. Drag the lone tab from window B to window A
3. Recently Closed Windows now has a menu entry for (Untitled).

Expected Behavior:
No new entry is added to the menu.

Proposed Solution:
One possibility is to just ignore empty windows in session store, though this
could possibly cause issues with the win/linux need for a non-popup window.

Comment 1

[[e-mail]]

Comment on attachment 395585 [details] [diff] [review]
patch

We can't actually switch tabs between windows yet but that's no excuse ;-)

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 395585 [details] [diff] [review]
patch


{
patching file suite/common/src/nsSessionStore.js
Hunk #2 FAILED at 528
1 out of 2 hunks FAILED
}
and I don't have a clue where the patch context comes from :-<

Comment 3

[Misak Khachatryan]

Comment on attachment 395585 [details] [diff] [review]
patch

I'm sorry for not stating this clear before, this patch should be applied after bug 510890, which is ready to land BTW.

Comment 4

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/0a8d10dcc759

Misak, feel free to resolve this bug if everything here is fixed! :)

Comment 5

[Robert Kaiser]

I accidentally pushed http://hg.mozilla.org/comm-central/rev/058aa5379fc7 with a comment pointing to this bug here, but it was actually for bug 510890. Just as a note if anyone follows this patch back to its origin.