If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

SeaMonkey doesn't need to initialise/use nsBrowserInstance

RESOLVED FIXED in seamonkey2.0b2

Status

SeaMonkey
Tabbed Browser
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
seamonkey2.0b2
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Created attachment 395630 [details] [diff] [review]
The fix (diff -w)

I noticed this the other day - since we switched to being a MOZ_XUL_APP and Bug 451909 removed the old code from it, nsBrowserInstance is effectively a no-op.

The main function used to kick the page cycler into action was startPageCycler but that is now empty, save for setting the flag.

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d5e4a3e10202

I'm going to be filing a bug to remove it from core, but here's the patch to remove the use from SeaMonkey first.
Attachment #395630 - Flags: superreview?(neil)
Attachment #395630 - Flags: review?(neil)
(Assignee)

Comment 1

8 years ago
Created attachment 395631 [details] [diff] [review]
The fix (normal patch)

Updated

8 years ago
Attachment #395630 - Flags: superreview?(neil)
Attachment #395630 - Flags: superreview+
Attachment #395630 - Flags: review?(neil)
Attachment #395630 - Flags: review+
(Assignee)

Comment 2

8 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/d06cf5cd8008
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Blocks: 511849
Flags: in-testsuite-
Target Milestone: --- → seamonkey2.0b2
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.