Closed
Bug 511850
Opened 15 years ago
Closed 8 years ago
Session Restore show about:blank tabs as Loading... at start up
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: tabmix.onemen, Unassigned)
References
Details
(Keywords: polish)
Session Restore show about:blank tabs as Loading... at start up
SessionStoreService restoreHistoryPrecursor have apply this lines also for tabs with about:blank
tab.setAttribute("busy", "true");
tabbrowser.updateIcon(tab);
tabbrowser.setTabTitleLoading(tab);
the function should check if the current entry isn't about:blank before mark the tab as loading
Comment 1•15 years ago
|
||
This is WFM on both trunk & 3.6 nightlies.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Comment 2•15 years ago
|
||
(In reply to comment #1)
> This is WFM on both trunk & 3.6 nightlies.
Yes, but not when crashing till about:sessionrestore comes up and then clicking on "Restore". Seeing this using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090824 Minefield/3.7a1pre ID:20090824030655 with a fresh profile. (Not reopening for now, waiting till we got another confirmation)
Reporter | ||
Comment 3•15 years ago
|
||
On new profile
open many blank tabs
restart Firefox, on start up ALL restored tab show as Loading...
for a short time
Comment 4•15 years ago
|
||
I'm seeing Loading... on the only two tabs of one windows after restart - both tabs windows are still blank.
Comment 5•15 years ago
|
||
Paul, I've just had a fascinating find ... I can do "close tab" on a tab that restored "empty" and undo loads the lost url and tab history.
Comment 6•15 years ago
|
||
(In reply to comment #5)
> Paul, I've just had a fascinating find ... I can do "close tab" on a tab that
> restored "empty" and undo loads the lost url and tab history.
Indeed. I've used that trick a fair amount :)
This is because at startup the data we're going to restore gets cached with the tab. We're getting an error before we try to restore the data for that tab, so we never clear that cached data. But when you close the tab, we look for that cached data (in case you close it/quit during startup before it's restored). That's the data we save for undo close tab.
(In reply to comment #4)
> I'm seeing Loading... on the only two tabs of one windows after restart - both
> tabs windows are still blank.
Can you try reproducing this and post/send your sessionstore.* files? If you can get it down to a simplified case, even better. If this was going from a nightly before the fix for bug 522545 landed, I wouldn't be surprised if that's what you were seeing. Followup on that bug if you can reproduce.
(In reply to comment #3)
> On new profile
> open many blank tabs
> restart Firefox, on start up ALL restored tab show as Loading...
> for a short time
Sorry I think I must have misinterpreted you before. I think I interpreted you to mean it stays showing "Loading...", not the short flicker. That does happen and this is not WFM
Comment 7•15 years ago
|
||
Mailed Paul non-reduced session.js files.
short version is I saw this on 20091119 (today's nightly), having previously been on 20091020. So yes, coming from a nightly before before bug 522545 landed on 2009-11-13. Very reproducible so far. "Loading..." however is not a major symptom. This is just the closest bug I happened upon initially. Will follow up tomorrow as needed depending on which issue(s) are reproducible.
Comment 8•15 years ago
|
||
(See also bug 531128, about restored tabs permanently titled "Loading..." from URLs that have become invalid since previous session.)
See Also: → 531128
Comment 9•8 years ago
|
||
I haven't seen this in ages. And reporter also says WFM (via mail)
Status: REOPENED → RESOLVED
Closed: 15 years ago → 8 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•