Created attachment 395841 [details] testcase See testcase, a print dialog should appear, this regressed when bug 352093 landed.
This was mentioned at http://forums.mozillazine.org/viewtopic.php?f=23&t=1434425&p=7307595#p7307595
Regression window: FAIL: http://hg.mozilla.org/mozilla-central/rev/026403392281 (30539) PASS: http://hg.mozilla.org/mozilla-central/rev/b01f80d5166a (30538)
So printing a frame somehow depends on that frame having a widget? Seems like it shouldn't...
This sucks actually. I tried to avoid supporting print preview of an iframe because I thought only chrome could do that, and although I guess that's still true, I didn't know content could print iframes. The problem is that the print engine expects a widget at the root and I don't know how hard it would be to fix that for printing --- I know it looked hard for print preview. Olli, would you possibly be able to look at this? I'm suspect your cloning patch fixes it but I guess we can't backport that to 1.9.2 :-(.
I'll look at this.
Assignee: nobody → Olli.Pettay
Created attachment 399289 [details] [diff] [review] patch We use mParentWidget only when creating print preview.
Attachment #399289 - Flags: review?(roc)
Comment on attachment 399289 [details] [diff] [review] patch Ahh, great!
Attachment #399289 - Flags: review?(roc) → review+
Martijn, do you know if it's possible to write a mochitest here? You can probably set a pref to disable the dialog box, but I guess the test output still goes to the default printer, and that would be bad...
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
status1.9.2: --- → beta1-fixed
Priority: P1 → P2
You need to log in before you can comment on or make changes to this bug.