511883 - window.print() doesn't work from inside a frame

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, a print dialog should appear, this regressed when bug 352093 landed.

Comment 1

[Martijn Wargers (dead)]

This was mentioned at http://forums.mozillazine.org/viewtopic.php?f=23&t=1434425&p=7307595#p7307595

Comment 3

[Curtis Bartley [:cbartley]]

Regression window:

FAIL: http://hg.mozilla.org/mozilla-central/rev/026403392281 (30539)
PASS: http://hg.mozilla.org/mozilla-central/rev/b01f80d5166a (30538)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So printing a frame somehow depends on that frame having a widget?  Seems like it shouldn't...

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This sucks actually. I tried to avoid supporting print preview of an iframe because I thought only chrome could do that, and although I guess that's still true, I didn't know content could print iframes. The problem is that the print engine expects a widget at the root and I don't know how hard it would be to fix that for printing --- I know it looked hard for print preview.

Olli, would you possibly be able to look at this? I'm suspect your cloning patch fixes it but I guess we can't backport that to 1.9.2 :-(.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I'll look at this.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

We use mParentWidget only when creating print preview.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 399289 [details] [diff] [review]
patch

Ahh, great!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Martijn, do you know if it's possible to write a mochitest here? You can probably set a pref to disable the dialog box, but I guess the test output still goes to the default printer, and that would be bad...

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/0439fc77c894

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4d62b8e4997a