Closed Bug 512060 Opened 15 years ago Closed 15 years ago

Casing errors in firefox/source/intl/uconv/src/charsetalias.properties prevent encoding aliases from working

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: pub-mozilla, Assigned: smontagu)

Details

Attachments

(1 file)

Patch
18.68 KB, patch
emk
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_5_8; en-us) AppleWebKit/531.9 (KHTML, like Gecko) Version/4.0.3 Safari/531.9
Build Identifier: 

<http://mxr.mozilla.org/firefox/source/intl/uconv/src/charsetalias.properties> clearly states that the
“key should always be in lower case ascii”, which is not the case for the following:

csIBM866
csIBM850
csIBM852
csIBM855
csIBM857
csIBM862
csIBM864
csMacintosh

As one would expect, these aliases do not work. Converting them to lowercase would presumably fix the problem.

Reproducible: Always
nsCharsetAlias2::GetPreferred does indeed use LowerCaseEqualsASCII to compare the alias. The actual comparison of the charset (in nsCharsetAlias2::Equals) is case-insensitive.
Assignee: nobody → smontagu
Status: UNCONFIRMED → NEW
Component: General → Internationalization
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → i18n
Version: unspecified → Trunk
Attached patch Patch — — Splinter Review 
Good catch!
Attachment #396085 - Flags: review?(VYV03354)
Flags: wanted1.9.2?
Attachment #396085 - Flags: review?(VYV03354) → review+
http://hg.mozilla.org/mozilla-central/rev/1be54db4e40c
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Summary: Casing errors in firefox/source/intl/uconv/src/charsetalias.properties prevents encoding aliases from working → Casing errors in firefox/source/intl/uconv/src/charsetalias.properties prevent encoding aliases from working
You need to log in before you can comment on or make changes to this bug.