512110 - Per-folder filters on newsgroups cannot be edited

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Kent James (:rkent)]

As a regression from bug 464770, per-folder filters for newsgroups cannot be edited. The displayed filter is always the server filter.

Comment 1

[Kent James (:rkent)]

Attachment: Add missing overrides in news

The issue was that we did not override the default getEditableFilterList functions in news, so that the per-folder features got added.

I also did a little change that shows up once this is fixed. In filterWidgets.xml, if you select a news-based per-folder filter in the filterlist dialog, and then try to change the selection to the server for that folder, the displayed selection does not change in the menu. This is because selectedIndex does not change in the menu, so the XBL for that figures that it does not have to update the label. But we are using a non-standard method of changing the label to be a mismatch to the selected index, so we have to restore it to the correct value. This might have manifestations elsewhere, but I could not find any.

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/c34080e699ea