Make "Delete History for (host|domain) available in History context menus

RESOLVED FIXED in seamonkey2.0b2

Status

SeaMonkey
UI Design
--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.66 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 396139 [details] [diff] [review]
proposed patch

This is the equivalent of Firefox bug 465082 (and bug 460086). The idea is to have "Delete History for (host|domain)" available in the context menu so that these commands can be used from the sidebar (the patch also adds it to the context menu available in the History window but there the commands are already available through the Edit menu).

Some background: the placesCmd_delete:* commands in controller.js check gLastHostname and gLastDomain which are only set by historyOnSelect() in history.js. To make it work in the Sidebar I had to call that function and make sure it doesn't access gHistoryStatus which is not available in the Sidebar case.
Attachment #396139 - Flags: review?(neil)
(Assignee)

Updated

8 years ago
Assignee: nobody → jh

Updated

8 years ago
Attachment #396139 - Flags: review?(neil) → review-

Comment 1

8 years ago
Comment on attachment 396139 [details] [diff] [review]
proposed patch

>+    <command id="placesCmd_delete:hostname"
>+             oncommand="goDoCommand('placesCmd_delete:hostname');"/>
>+    <command id="placesCmd_delete:domain"
>+             oncommand="goDoCommand('placesCmd_delete:domain');"/>
Nit: these can now be removed from history.xul

>     <menuitem id="placesContext_delete"
>               command="cmd_delete"
>               label="&deleteCmd.label;"
>               accesskey="&deleteCmd.accesskey;"
>               selection="link|host|day"/>
>+    <menuitem id="menu_deleteByHostname"
>+              command="placesCmd_delete:hostname"
>+              selection="link|host"/>
>+    <menuitem id="menu_deleteByDomain"
>+              command="placesCmd_delete:domain"
>+              selection="link|host"/>
This breaks the Edit menu, since you have duplicate IDs. One workaround is to set the label and accesskey on the command element instead.
(Assignee)

Comment 2

8 years ago
Created attachment 396818 [details] [diff] [review]
patch v2

Now with different IDs. Had to switch over to using setAttribute() for both .label and .accessKey now that the target is a command element.
Attachment #396139 - Attachment is obsolete: true
Attachment #396818 - Flags: superreview?(neil)
Attachment #396818 - Flags: review?(neil)

Updated

8 years ago
Attachment #396818 - Flags: superreview?(neil)
Attachment #396818 - Flags: superreview+
Attachment #396818 - Flags: review?(neil)
Attachment #396818 - Flags: review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Pushed: http://hg.mozilla.org/comm-central/rev/c98edd97fb3f
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
You need to log in before you can comment on or make changes to this bug.