512190 - nsBlockFrame.cpp calls protected function (won't compile) when compiled with -fexceptions

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[Takanori MATSUURA]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; ja-JP; rv:1.9.3a1pre) Gecko/20090818 Fedora/3.7a1pre-0.a1pre.2009081716.hg_8ea02ebd43f0.fc11 Minefield/3.7a1pre
Build Identifier: 

When I compile nsBlockFrame.cpp with gcc-4.1.1, it fails as below:

c++ -o nsBlockFrame.o -c -I../../dist/system_wrappers -include ../../config/gcc_hidden.h -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"Linux2.6.29.6-217.2.3.fc11\" -DOSARCH=Linux -D_IMPL_NS_LAYOUT -I. -I./../base -I./../forms -I./../tables -I./../xul/base/src -I./../../content/xul/content/src -I./../../content/base/src -I./../../content/html/content/src -I./../../dom/base -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12    -I. -I. -I../../dist/include -I../../dist/include/nsprpub  -I/usr/include/nspr4 -I/usr/include/nss3         -fPIC   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions  -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-unix-print-2.0     -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/nsBlockFrame.pp nsBlockFrame.cpp
nsFrame.h: In member function 'virtual nsresult nsBlockFrame::SetInitialChildList(nsIAtom*, nsFrameList&)':
nsFrame.h:153: error: 'static void nsFrame::operator delete(void*, size_t)' is protected
nsBlockFrame.cpp:6526: error: within this context

Reproducible: Always

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Where did you get the source code?  Do you know what revision of nsBlockFrame.cpp it is?

nsBlockFrame.cpp compiles fine for me and for many other people.

Might you have some mozilla headers installed as system headers somehow?

Comment 2

[Takanori MATSUURA]

I have tested with newly cloned 2e8b6f1bf670 and get the same error.

I can build with 8ea02ebd43f0 and cannot build with 8bb50c6982c4.  The same configuration was used for both builds.

I found that this error occurs when "-fexceptions" is added to CFLAGS and CXXFLAGS.
(and Fedora RPM build system sets this option as default)

Are there any exception handling issue?

Comment 3

[Takanori MATSUURA]

Attachment: Diff between 8ea02ebd43f0 and 8bb50c6982c4

Comment 4

[Takanori MATSUURA]

Attachment: fix

This works fine for me.
The original one is from xulrunner-1.9.2.1-0.2.fc13.src.rpm from Fedora koji building system.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 413497 [details] [diff] [review]
fix

Why is the Fedora RPM compiling with -fexceptions?  They shouldn't be, and I don't think we want to support that; our code certainly isn't exception-safe.

We also want the protection that the |protected| gives us here.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to comment #5)
> Comment on attachment 413497 [details] [diff] [review]
> fix
> 
> Why is the Fedora RPM compiling with -fexceptions?  They shouldn't be, and I
> don't think we want to support that; our code certainly isn't exception-safe.
> 
> We also want the protection that the |protected| gives us here.

-fexceptions comes from standard Fedora build flags, we need to fix it.