512321 - hit setupBuild exception at the start of l10nverify in firefox 3.5.3 release

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Probably an import/reload problem tripped by the master splitout.

Comment 1

[[e-mail] (:bhearsum)]

Here's the exception:
2009/08/24 13:47 PDT [HTTPChannel,260,10.2.72.11] 10.2.72.11 - - [24/Aug/2009:20        --- <exception caught here> ---
          File "/tools/buildbot/lib/python2.5/site-packages/buildbot/process/base.py", line 351, in startBuild
            self.setupBuild(expectations) # create .steps
          File "/tools/buildbot/lib/python2.5/site-packages/buildbot/process/base.py", line 401, in setupBuild
            step = factory(**args)
          File "/tools/buildbotcustom/buildbotcustom/steps/release.py", line 28, in __init__
            TinderboxShellCommand.__init__(self, ignoreCodes=[0,1], **kwargs)
        <type 'exceptions.TypeError'>: unbound method __init__() must be called with TinderboxShellCommand instance as first argument (got L10nVerifyMetaDiff instance instead)

Comment 2

[[e-mail] (:bhearsum)]

Attachment: removed second reload of buildbotcustom.steps.misc

I'm pretty sure this is caused by the double reload of buildbotcustom.steps.misc - one by factory.py, and another in steps/release.py. The former is called first, when misc.py gets imported. The latter is done when release_master.py gets processed.

Let's try removing the second one. steps/release.py's only consumer is factory.py (and ccfactory.py, which is a consumer of factory.py) so we should be able to safely remove it.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 396290 [details] [diff] [review]
removed second reload of buildbotcustom.steps.misc

changeset:   397:9a587b917756

Comment 4

[[e-mail] (:bhearsum)]

Attachment: move buildbotcustom.misc import

The first patch didn't work. buildbotcustom.steps.release ended up with the current buildbotcustom.steps.misc, but when buildbotcustom.misc was reloaded in master2.cfg the buildbotcustom.steps.misc address changed. If we reload buildbotcustom.misc before buildbotcustom.steps.release grabs the outdated address we should be fine (no really).

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 396294 [details] [diff] [review]
move buildbotcustom.misc import

ichangeset:   1462:5b1820fab855

Comment 6

[[e-mail] (:bhearsum)]

The combination of these two patches fixed us up.