Identity panel text layout is wrong

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: madhava, Assigned: mfinkle)

Tracking

(Blocks: 1 bug)

Trunk
x86
Mac OS X

Details

(Whiteboard: [polish])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
For an example, go here:

https://www.britishairways.com/travel/globalgateway.jsp/global/public/en_

and then tap on the larry (site) button.
(Reporter)

Updated

9 years ago
Blocks: 477628
Created attachment 396391 [details] [diff] [review]
patch

Turns out this is a Mac-only bug (yay!?)

Mac CSS doesn't set the start/end margins for labels and descriptions, while Windows and Linux do. This patch sets the start/end margins to the Windows/Linux values. Redundant for Windows & Linux, but needed for Mac.
Assignee: nobody → mark.finkle
Attachment #396391 - Flags: review?(gavin.sharp)
Attachment #396391 - Flags: review?(gavin.sharp) → review+
pushed: https://hg.mozilla.org/mobile-browser/rev/ee4a34fbeaa3
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

9 years ago
Created attachment 396758 [details]
better description of the problem

I think I should have been more specific.  Here's a diagram with the problem flagged.

(also, if we can concatenate strings, maybe use some commas)
(Reporter)

Updated

9 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

9 years ago
tracking-fennec: ? → 1.0+
Keywords: polish
(Reporter)

Updated

9 years ago
Keywords: polish
Whiteboard: [polish]
(Reporter)

Comment 5

9 years ago
Spacing issues or no, this is far better than what we have currently.  What are the spacing issues?
(Assignee)

Updated

9 years ago
Attachment #396771 - Flags: review?(gavin.sharp)
Comment on attachment 396771 [details] [diff] [review]
patch 2

I don't really understand why display: block on the hbox has an effect here, can you explain?
hbox { display: block} will allow the contents to wrap like in an html div. This means if the container is wide enough, the owner & address text will appear on one line. If not, it will wrap so the address text is one a second line.
Attachment #396771 - Flags: review?(gavin.sharp) → review+
Comment on attachment 396771 [details] [diff] [review]
patch 2

Seems like we should probably just use an actual html:div instead, then? Does the flex="1" do anything? I don't know xul well enough to suggest a better alternative, so if it works...
(In reply to comment #8)
> (From update of attachment 396771 [details] [diff] [review])
> Seems like we should probably just use an actual html:div instead, then? Does
> the flex="1" do anything? I don't know xul well enough to suggest a better
> alternative, so if it works...

hbox { display: block; } is pretty handy. Enn told me about it, so I assume it's a known feature and not a side-effect.

The flex on the hbox only works in the vertical, so it's not helpful here.
pushed:
https://hg.mozilla.org/mobile-browser/rev/05f7355b93e6
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091006
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091006
Fennec/1.0b4

Follow-up bug 520786 was filed for the Omnia 2.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.