512332 - Identity panel text layout is wrong

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

For an example, go here:

https://www.britishairways.com/travel/globalgateway.jsp/global/public/en_

and then tap on the larry (site) button.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Turns out this is a Mac-only bug (yay!?)

Mac CSS doesn't set the start/end margins for labels and descriptions, while Windows and Linux do. This patch sets the start/end margins to the Windows/Linux values. Redundant for Windows & Linux, but needed for Mac.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/ee4a34fbeaa3

Comment 3

[Madhava Enros [:madhava]]

Attachment: better description of the problem

I think I should have been more specific.  Here's a diagram with the problem flagged.

(also, if we can concatenate strings, maybe use some commas)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch yields a better result, but has spacing issues.

Screenshots:
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-identity-layout-03.png
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-identity-layout-05.png

Comment 5

[Madhava Enros [:madhava]]

Spacing issues or no, this is far better than what we have currently.  What are the spacing issues?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 396771 [details] [diff] [review]
patch 2

I don't really understand why display: block on the hbox has an effect here, can you explain?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

hbox { display: block} will allow the contents to wrap like in an html div. This means if the container is wide enough, the owner & address text will appear on one line. If not, it will wrap so the address text is one a second line.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 396771 [details] [diff] [review]
patch 2

Seems like we should probably just use an actual html:div instead, then? Does the flex="1" do anything? I don't know xul well enough to suggest a better alternative, so if it works...

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)
> (From update of attachment 396771 [details] [diff] [review])
> Seems like we should probably just use an actual html:div instead, then? Does
> the flex="1" do anything? I don't know xul well enough to suggest a better
> alternative, so if it works...

hbox { display: block; } is pretty handy. Enn told me about it, so I assume it's a known feature and not a side-effect.

The flex on the hbox only works in the vertical, so it's not helpful here.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/05f7355b93e6

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091006
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091006
Fennec/1.0b4

Follow-up bug 520786 was filed for the Omnia 2.