Closed Bug 512338 Opened 15 years ago Closed 15 years ago

Make the traversal in nsSVGUtils::HitTestChildren use GetPrevSibling

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

At least once bug 512336 implements it.
Attached patch FixSplinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #400828 - Flags: review?
Attachment #400828 - Flags: review? → review?(jwatt)
Comment on attachment 400828 [details] [diff] [review]
Fix

>+  for (nsIFrame* current = aFrame->GetChildList(nsnull).LastChild();

Kinda surprised you think GetFirstChild/GetLastChild should go away since they seem much nicer than the GetChildList(nsnull) gunk to me, but r=jwatt. Glad to see this happen!
Attachment #400828 - Flags: review?(jwatt) → review+
The issue is people getting the first child and then doing boneheaded things with it, which they wouldn't do if they realized they have a framelist available... ;)

Thanks for the review!
Pushed http://hg.mozilla.org/mozilla-central/rev/26d5186da496
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: