512378 - Port |Bug 506985 - remove java-specific preferences from Firefox UI, hidden prefs| to SeaMonkey 2.1

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Serge Gautherie (:sgautherie)]

Remove obsolete preference (code).

Comment 1

[Serge Gautherie (:sgautherie)]

This can wait until c-c branches.

Comment 2

[Edmund Wong (:ewong)]

Serge, 2.1 has been released.  Which branch should this be ported for?

Comment 3

[Serge Gautherie (:sgautherie)]

Summary:

*SeaMonkey skipped *-1.9.2.
*SeaMonkey 2.1 has been released: marking as WontFix there.
*SeaMonkey 2.2+ still want this, unless branch is already code frozen.

Remember to remove the 2 strings in non string frozen branches too:
http://mxr.mozilla.org/comm-central/search?string=enbJavaCheck.&case=1&find=%2Fsuite%2F

Comment 4

[Ian Neal]

2.2 is string frozen
2.3 will be in the next week or so once 2.2 comes out

Comment 5

[Edmund Wong (:ewong)]

Attachment: Removed java-specific preferences from SeaMonkey UI and hidden prefs.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 544990 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs.

Review of attachment 544990 [details] [diff] [review]:
-----------------------------------------------------------------

Clean /suite/profile/migration/src/ns*ProfileMigrator.cpp up too.

::: suite/locales/en-US/chrome/common/pref/pref-advanced.dtd
@@ +1,5 @@
>  <!--LOCALIZATION NOTE : FILE 'Advanced' prefs settings -->
>  <!ENTITY pref.advanced.title        "Advanced">
>  
>  <!ENTITY prefEnableJava.caption     "Features that help interpret web pages">
>  

Remove lines 4-5 too.

Comment 7

[Ian Neal]

Comment on attachment 544990 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs.

As Serge said, u missed a line from the .dtd file and there is also the profile migration files.
http://mxr.mozilla.org/comm-central/search?string=security\.enable_java&regexp=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Should be just a matter of deleting the two lines that mention security.enable_java
Any help need updating too?

Comment 8

[Edmund Wong (:ewong)]

Attachment: Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v2)

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 545039 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v2)

Maybe "<p>The main Advanced preferences panel allows you to ..." should be kept, but updated to something more generic (= up-to-date at least)?

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 545039 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v2)

>   <li class="unix"><strong>Use Preferences from System</strong>: Select this to
>     use the already set system preferences, overriding &brandShortName;&apos;
>     ones.

I don't have Linux, so I wonder: is this other pref (un)related to Java?

Comment 11

[Ian Neal]

Comment on attachment 545039 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v2)

>+++ b/suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml
>@@ -46,23 +46,17 @@
>-<p>The main Advanced preferences panel allows you to enable or disable
>-  Java:</p>
Leave this in but change to <p class="unix"> and remove the "enable or disable Java" bit so it now reads:
<p class="unix">The main Advanced preferences panel allows you to:</p>

r=me with that sorted.

Comment 12

[Edmund Wong (:ewong)]

Attachment: Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v3) [Checked in: Comment 13]

Comment 13

[Ian Neal]

Comment on attachment 545158 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v3) [Checked in: Comment 13]

http://hg.mozilla.org/comm-central/rev/f7b16da534a1

Comment 14

[[e-mail]]

Is this worth a) relnoting b) landing non-l10n changes on branches?

Comment 16

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #14)
> Is this worth a) relnoting

Sure, done (for 2.2 only, see next point).

> b) landing non-l10n changes on branches?

Having useless UI just adds confusion, so I'd vote for copying all changes except the pref-advanced.dtd ones to branches (given that Help changes are allowed as long as no files are added/removed/renamed).

Comment 17

[Dick Hoffman]

This is not fixed in SM 2.2; the preference, albeit inoperative, is still present and checking the UI checkbox toggles it between True and False. The result is a  security exposure; the naive user thinks Java is being Enabled and Disabled but the default Enabled cannot be changed using the preference, but only via the Add-ons Manager.

Comment 18

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #17)
> This is not fixed in SM 2.2

No-one said it was. The Target Milestone is currently SM 2.5 and it has been relnoted for SM 2.2 (granted, only yesterday, see comment 16). If it won't make SM 2.3 or SM 2.4, it will be relnoted for these, too.

Comment 19

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 545158 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v3) [Checked in: Comment 13]

Requesting permission to land everything but the pref-advanced.dtd changes on Aurora and Beta.

Comment 20

[Justin Wood (:Callek)]

Comment on attachment 545158 [details] [diff] [review]
Removed java-specific preferences from SeaMonkey UI and hidden prefs and help. (v3) [Checked in: Comment 13]

a+ provided the .dtd does not land.

Comment 21

[Jens Hatlak (:InvisibleSmiley)]

http://hg.mozilla.org/releases/comm-aurora/rev/73eba6d39764
http://hg.mozilla.org/releases/comm-beta/rev/0a3ac1c46c65

Comment 22

[Axel Hecht [:Pike]]

No idea how you guys handle this, but this did change the localizable help files.

Comment 23

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #22)
> No idea how you guys handle this, but this did change the localizable help
> files.

Our policy is that Help changes are allowed as long as no files are added/removed/renamed (see comment 16).