512416 - Suppression of junk whitelisting does not work for deferred to server

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Kent James (:rkent)]

Junk whitelisting by default is suppressed if the from address matches an identity of the user. But this is not working if the server processing the junk mail is a deferred-to server (like POP3 going to the Local Folders account). This is because the list of email addresses that are determined to be "my" addresses are not being calculated properly.

I think that the proper thing to do is to scan for servers that defer to the current server, and add their email addresses to the "don't whitelist this address" list. I suppose that we could still have failures where people are using filters to copy to a different server, but we can probably live with that.

Comment 1

[Kent James (:rkent)]

Attachment: Suppress whitelisting for deferred-from identities

Here's the patch. I want to look it over and run with it for a day though.

The other possible approach would be to suppress whitelisting for all emails addresses for all identities. That would also catch the filtered emails. Any opinions on this are welcome.

Comment 2

[Kent James (:rkent)]

Attachment: Removed unneeded nsISupportsArray create [Checkin: Comment 4]

Comment 3

[David :Bienvenu]

Comment on attachment 398177 [details] [diff] [review]
Removed unneeded nsISupportsArray create
[Checkin: Comment 4]

looks reasonable. I think you might end up with duplicates in mEmails if identities are shared, but it shouldn't hurt anything.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 398177 [details] [diff] [review]
Removed unneeded nsISupportsArray create
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/f1e9c400862d