Suppression of junk whitelisting does not work for deferred to server

RESOLVED FIXED in Thunderbird 3.0b4

Status

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

Trunk
Thunderbird 3.0b4
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Junk whitelisting by default is suppressed if the from address matches an identity of the user. But this is not working if the server processing the junk mail is a deferred-to server (like POP3 going to the Local Folders account). This is because the list of email addresses that are determined to be "my" addresses are not being calculated properly.

I think that the proper thing to do is to scan for servers that defer to the current server, and add their email addresses to the "don't whitelist this address" list. I suppose that we could still have failures where people are using filters to copy to a different server, but we can probably live with that.
Here's the patch. I want to look it over and run with it for a day though.

The other possible approach would be to suppress whitelisting for all emails addresses for all identities. That would also catch the filtered emails. Any opinions on this are welcome.
Whiteboard: [has patch]
Attachment #398005 - Attachment is obsolete: true
Attachment #398177 - Flags: superreview?(bienvenu)
Attachment #398177 - Flags: review?(bienvenu)
Whiteboard: [has patch] → [needs r/sr bienvenu]
Target Milestone: --- → Thunderbird 3.0b4
Attachment #398177 - Flags: superreview?(bienvenu)
Attachment #398177 - Flags: superreview+
Attachment #398177 - Flags: review?(bienvenu)
Attachment #398177 - Flags: review+
Comment on attachment 398177 [details] [diff] [review]
Removed unneeded nsISupportsArray create
[Checkin: Comment 4]

looks reasonable. I think you might end up with duplicates in mEmails if identities are shared, but it shouldn't hurt anything.
Whiteboard: [needs r/sr bienvenu]
Keywords: checkin-needed
Comment on attachment 398177 [details] [diff] [review]
Removed unneeded nsISupportsArray create
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/f1e9c400862d
Attachment #398177 - Attachment description: Removed unneeded nsISupportsArray create → Removed unneeded nsISupportsArray create [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Depends on: 515159
You need to log in before you can comment on or make changes to this bug.