Last Comment Bug 512454 - Improve the look of the inline attachment separator.
: Improve the look of the inline attachment separator.
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.0b2
Assigned To: Blake Winton (:bwinton) (:☕️)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-25 06:32 PDT by Blake Winton (:bwinton) (:☕️)
Modified: 2009-08-28 08:38 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
A patch for theme changes to SeaMonkey. (1.97 KB, patch)
2009-08-25 06:32 PDT, Blake Winton (:bwinton) (:☕️)
neil: review+
Details | Diff | Review
The previous patch, with Neil's and Andreas's suggestions [Checkin: Comment 4] (3.59 KB, patch)
2009-08-25 08:42 PDT, Blake Winton (:bwinton) (:☕️)
neil: review+
bugs: ui‑review+
Details | Diff | Review

Description Blake Winton (:bwinton) (:☕️) 2009-08-25 06:32:59 PDT
Created attachment 396426 [details] [diff] [review]
A patch for theme changes to SeaMonkey.

In bug 509616 I made some changes to Thunderbird to make the attachment separator prettier, but I couldn't get a working build of SeaMonkey to test similar changes to it, so I left them out of that patch.

Anyways, here are the theme changes, still untested, and a fix for a nit that Neil found after it was checked in.

Thanks,
Blake.
Comment 1 neil@parkwaycc.co.uk 2009-08-25 07:53:52 PDT
Comment on attachment 396426 [details] [diff] [review]
A patch for theme changes to SeaMonkey.

(Applies to both themes)
>+.mimeAttachmentHeader {
>+  width: 98%;
Because of the way widths are calculated, this is actually relative to the window width, not the automatic width (which is 20px less). This means that if your window is 1000 pixels wide then the size works out to be the same and if your window is narrow then this actually makes the fieldset wider!

I guess you have three options:
1. Make the width less. 97% is borderline, 96% would be better, or even less.

2. Don't set the width; just use the defaults.

3. As 2. but also set an end margin, e.g. use -moz-margin-end: 2%;
(You may also want to set a start margin, to override the default 2px.)
Comment 2 Blake Winton (:bwinton) (:☕️) 2009-08-25 08:42:23 PDT
Created attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]
Comment 3 Andreas Nilsson (:andreasn) 2009-08-26 06:18:25 PDT
Comment on attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]

Tested on Linux, OS X and Vista. Looks good!
Comment 4 Serge Gautherie (:sgautherie) 2009-08-28 08:37:16 PDT
Comment on attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/a39d775470fc

Note You need to log in before you can comment on or make changes to this bug.