Improve the look of the inline attachment separator.

RESOLVED FIXED in seamonkey2.0b2

Status

SeaMonkey
Themes
--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bwinton, Assigned: bwinton)

Tracking

Trunk
seamonkey2.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 396426 [details] [diff] [review]
A patch for theme changes to SeaMonkey.

In bug 509616 I made some changes to Thunderbird to make the attachment separator prettier, but I couldn't get a working build of SeaMonkey to test similar changes to it, so I left them out of that patch.

Anyways, here are the theme changes, still untested, and a fix for a nit that Neil found after it was checked in.

Thanks,
Blake.
Attachment #396426 - Flags: review?(neil)

Comment 1

8 years ago
Comment on attachment 396426 [details] [diff] [review]
A patch for theme changes to SeaMonkey.

(Applies to both themes)
>+.mimeAttachmentHeader {
>+  width: 98%;
Because of the way widths are calculated, this is actually relative to the window width, not the automatic width (which is 20px less). This means that if your window is 1000 pixels wide then the size works out to be the same and if your window is narrow then this actually makes the fieldset wider!

I guess you have three options:
1. Make the width less. 97% is borderline, 96% would be better, or even less.

2. Don't set the width; just use the defaults.

3. As 2. but also set an end margin, e.g. use -moz-margin-end: 2%;
(You may also want to set a start margin, to override the default 2px.)
Attachment #396426 - Flags: review?(neil) → review+
(Assignee)

Comment 2

8 years ago
Created attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]
Attachment #396426 - Attachment is obsolete: true
Attachment #396443 - Flags: ui-review?(nisses.mail)
Attachment #396443 - Flags: review?(neil)

Updated

8 years ago
Attachment #396443 - Flags: review?(neil) → review+
Comment on attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]

Tested on Linux, OS X and Vista. Looks good!
Attachment #396443 - Flags: ui-review?(nisses.mail) → ui-review+
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Assignee: nobody → bwinton
Keywords: checkin-needed
Comment on attachment 396443 [details] [diff] [review]
The previous patch, with Neil's and Andreas's suggestions
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/a39d775470fc
Attachment #396443 - Attachment description: The previous patch, with Neil's and Andreas's suggestions. → The previous patch, with Neil's and Andreas's suggestions [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.