OS/2 don't link against external libs that are stubs when the real function is in libc

VERIFIED FIXED in mozilla1.9.3a1

Status

Firefox Build System
General
VERIFIED FIXED
9 years ago
2 months ago

People

(Reporter: Walter Meinl, Assigned: Walter Meinl)

Tracking

Trunk
mozilla1.9.3a1
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.2) Gecko/20090802 Firefox/3.5.2
Build Identifier: 

Dave stated in bug511945 c#6 that linking against (lib)dl and (lib)socket and all the math stuff (e.g. (lib)m) is not necessary as all the functions needed are provided by libc. In my tree I removed all occurrences like -lsocket -ldl and -lm and got a well running browser, even flash 7R14 worked.
We should remove these dependencies, because they make trouble in bug511945 and might make trouble in the future. Particularly since we probably do not gain anything from them. 


Reproducible: Always
(Assignee)

Comment 1

9 years ago
Dave, since your patch attached to bug511945 isn't the real solution for that bug, I'd like to ask you to attach it here (can you attach a CVS patch? If not I can do it for you).
I'll attach a patch for the main tree and js/src.
Version: unspecified → Trunk
(Assignee)

Comment 2

9 years ago
Created attachment 396481 [details] [diff] [review]
remove linking against socket dl and m from the build tree (except nspr)
Assignee: nobody → wuno
Status: NEW → ASSIGNED
Attachment #396481 - Flags: review?(mozilla)
(Assignee)

Comment 3

9 years ago
Created attachment 396487 [details] [diff] [review]
corrected version

forgot to sync js/src/configure.in after editing a comment in configure.in
Attachment #396481 - Attachment is obsolete: true
Attachment #396487 - Flags: review?(mozilla)
Attachment #396481 - Flags: review?(mozilla)

Comment 4

9 years ago
Created attachment 396641 [details] [diff] [review]
Remove libldl and libsocket from nsprpub/configure.in

Walter, I believe I have created this patch according to the guidelines, if not can you recreate it and tell me the correct command.
Attachment #396641 - Flags: review?(mozilla)
(Assignee)

Comment 5

9 years ago
Created attachment 396681 [details] [diff] [review]
Dave's patch against nspr configure diffed against nspr cvs HEAD

IIRC, nspr and nss patches should be attached as diff's against CVS HEAD of nspr/nss. I updated my nspr tree to HEAD applied Dave's hg patch and rediffed using cvs -d -p -u8.

Comment 6

9 years ago
Comment on attachment 396487 [details] [diff] [review]
corrected version

Yes, this should be OK. Although in principle, I think, one should have different patches for the main mozilla-central build stuff and stuff in js/.
Attachment #396487 - Flags: review?(mozilla) → review+

Updated

9 years ago
Attachment #396641 - Flags: review?(mozilla)

Comment 7

9 years ago
Comment on attachment 396641 [details] [diff] [review]
Remove libldl and libsocket from nsprpub/configure.in

While I'm sure this is OK, NSPR stuff really needs to go into a separate bug (and then wtc should review it).

Comment 8

9 years ago
I won't have time to check this in...
Keywords: checkin-needed

Updated

9 years ago
Attachment #396641 - Attachment is obsolete: true

Updated

9 years ago
Attachment #396681 - Attachment is obsolete: true

Comment 9

9 years ago
http://hg.mozilla.org/mozilla-central/rev/582caefb4cf1
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1
(Assignee)

Updated

8 years ago
Status: RESOLVED → VERIFIED

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.