512507 - Port Bug 484329 - Upgrading to 3.0 causes "archives" folder disappears

Status: NEW

(SeaMonkey :: MailNews: General, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Fixing this bug should make sure that an Archives folder with a different case is used if present instead of hiding it from the UI. Final patch for the TB bug to be ported: <http://hg.mozilla.org/comm-central/rev/998e17e4acd6>

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: proposed patch

Straight port (only adjusted comments and bracing style).

Comment 2

[Karsten Düsterloh]

Comment on attachment 397656 [details] [diff] [review]
proposed patch

>diff --git a/suite/mailnews/mailWindowOverlay.js b/suite/mailnews/mailWindowOverlay.js
>+      let identity;

Initialize identity.

>+        identity = getIdentityForHeader(msgs[0]);

My shell says "ReferenceError: getIdentityForHeader is not defined", because ours is named GetIdentityForHeader. Furthermore, the function takes a second parameter, which you should pass in null for here.

>+        let ciArchive = null;
>+        ciArchive = archiveFolder.server.rootFolder
>+                                 .getChildWithURI(archiveFolderUri, true, true);

Why assign null first and kill that right away again?!


Furthermore, all my tests regarding the problem claimed to be fixed failed...
Let's see how the discussion in bug 484329 comment 10 and following turns out.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v1a

(In reply to comment #2)
> Furthermore, all my tests regarding the problem claimed to be fixed failed...
> Let's see how the discussion in bug 484329 comment 10 and following turns out.

I don't want to forget this here so I'm attaching the updated patch, feel free to delay the review until you have an answer.

BTW: You may consider adding your nick (e.g. in parentheses with leading colon as seen elsewhere), maybe it helps people like WADA to recognize you. ;-)

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 400382 [details] [diff] [review]
patch v1a

Effectively, the last review result was r-. Updating attachment details to
reflect that, and unassigning myself since I'm not actively working on this.