512524 - Unable to set image as desktop background

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Peter Pennington]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a2pre) Gecko/20090825 Namoroka/3.6a2pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a2pre) Gecko/20090825 Namoroka/3.6a2pre (.NET CLR 3.5.30729)

Find any web page with an image and right click to produce 'Set as desk top background'.  Left click topic and nothing happens.

Reproducible: Always

Steps to Reproduce:
1. Find page with image such as http://www.cornwallcam.co.uk/
2. Right click to produce menu with item 'Set as desk top background
3. Left click topic
Actual Results:  
Nothing

Expected Results:  
Desk top wallpaper to have a new image

hhh is possibly tracking back to find time of regression. He reports same issue on XP but not on Linux

Comment 1

[hhh]

I can confirm using Windows XP.

Works with...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090801 Minefield/3.6a1pre

Fails with...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090802 Minefield/3.6a1pre

WFM on Ubuntu 9.04 using the latest i686 nightly.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hass, do you have the changesets between these two builds? See about:buildconfig.

Comment 3

[Danial Horton]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090825 Namoroka/3.6a2pre GTB5 (.NET CLR 3.5.30729) ID:20090825052618

also happening here.

Comment 4

[hhh]

re: Comment #2
20090801 build...
http://hg.mozilla.org/mozilla-central/rev/c99ec9f95c64
20090802 build...
http://hg.mozilla.org/mozilla-central/rev/8366e5cc9f57

I can look for the hourly build where this breaks in about 3 hours from now if that will help.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That should not be necessary. Given the following link it's clear which patch caused this regression. Bug 507032 is the culprit.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c99ec9f95c64&tochange=8366e5cc9f57

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

To be clear, is this failing AFTER the dialog shows up and you click "Set Desktop Background" in the dialog? (that's where it's happening for me)

Comment 7

[hhh]

@Paul, yes.
1. View image.
2. Set position to any of the 3 options.
3. Click "Set as Desktop Background".
4. The Set Desktop Background closes but the wallpaper does not set.

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Tested locally (on XP) and it works. I'll kick off a build to triple check that it works on WinCE (that other issue non-withstanding).

Comment 9

[[not reading bugmail]]

Noting it also affects the trunk.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20090825 Minefield/3.7a1pre (.NET CLR 3.5.30729)

Comment 10

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #8)
> (that other issue non-withstanding).

To be clear for those of you who are not me or Rob, it looks like the work in bug 507302 wasn't quite right & that while the registry is set, the system wasn't redrawing the desktop.

Comment 11

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

pushed http://hg.mozilla.org/mozilla-central/rev/eb492ba316a8

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090830 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20090830050200

Do we have any tests in this area?

Comment 13

[[not reading bugmail]]

This needs a push to the 1.9.2 branch.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #13)
> This needs a push to the 1.9.2 branch.

No it doesn't. The patch on bug 507032 hasn't been checked into 1.9.2 yet. So this regression is trunk only.

Comment 15

[Peter Pennington]

(In reply to comment #14)
> (In reply to comment #13)
> > This needs a push to the 1.9.2 branch.
> 
> No it doesn't. The patch on bug 507032 hasn't been checked into 1.9.2 yet. So
> this regression is trunk only.

I made the initial report and it was found on branch

Comment 16

[[not reading bugmail]]

I just confirmed today's branch doesn't WFM.  The relationship between bug 507302 and bug 507032 is not clear with this one.

Comment 17

[u88484]

Well branch happened on the 13 or 14th and the patch in bug 507032 landed on the 1st so this is on the branch.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 396613 [details] [diff] [review]
Patch v0.1

Sorry, that was my fault. Paul, I hope its ok for you that I ask for approval1.9.2 on your patch.

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 396613 [details] [diff] [review]
Patch v0.1

And one more fault. It is already marked as blocker for 1.9.2. So only a check-in is needed.

Comment 20

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #12)
> Do we have any tests in this area?

Sadly not really. There's a specific Linux crash test but that's it. We do need more. I filed bug 513349 for that.

I'll check this in today. We weren't green enough on branch Friday, else I would have done so already.

Comment 21

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0399a48945ff

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090902 Namoroka/3.6a2pre (.NET CLR 3.5.30729) ID:20090902052327

Comment 23

[Peter Pennington]

Thanks, everybody