512559 - Use XUL template sorting to sort the add-ons lists

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

In order to properly sort the contents of two separate datasources into the same list we should just switch to using the XUL template sorting functions rather than doing it manually. The exception is the search pane where we have heard and footer items that have to be where we want them to be.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Some nice code removal here though since it is an API change it requires SR. There is no reason that others should be calling these functions though.

Comment 2

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/a81a4395dac3

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 397401 [details] [diff] [review]
patch rev 1

This is necessary for the lightweight themes UI, it also drops some interface methods so we need to land it before b1.

Comment 4

[Johnathan Nightingale [:johnath]]

If this is necessary for lightweight themes UI, which blocks, then this blocks.

Comment 5

[Dave Townsend [:mossop]]

Landed on branch: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/50d0ce028d8c