512564 - Support for the WinCE environment implementation

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[Robert Strong (they/them - no direct email)]

App update needs a little more work to properly support the WinCE environment implementation... patch coming up

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

only change from the first patch is the use of argOffset for checking if the updater should launch the callback app

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 396572 [details] [diff] [review]
patch rev2

>diff --git a/toolkit/mozapps/update/src/updater/updater.cpp b/toolkit/mozapps/update/src/updater/updater.cpp
>--- a/toolkit/mozapps/update/src/updater/updater.cpp
>+++ b/toolkit/mozapps/update/src/updater/updater.cpp
>...
>-  if (argc > 4)
>-    LaunchCallbackApp(argv[3], argc - 4, argv + 4);
>+  const int argOffset = 4;
>+  if (argc > argOffset) {
>+    // Argument that contains the callback executable. All arguments before this
>+    // argument are skipped.
I've moved this comment locally to before
>+  const int argOffset = 4;

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev3 w/ updated comments

Comment 5

[Robert Strong (they/them - no direct email)]

This affects our WinCE update so requesting blocking 1.9.2

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/83187d033954

Comment 7

[Robert Strong (they/them - no direct email)]

pushed to mozilla-1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e4d5bb4de0b4

Comment 8

[Robert Strong (they/them - no direct email)]

If this were to be put in the test suite the pre-existing Windows CE environment implementation that this leverages should first be in the test suite.