512571 - Pass on symbolsPath to packaged xpcshell-tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We don't get crash stacks from packaged xpcshell-tests because the path to the symbols isn't passed on the command line:
http://hg.mozilla.org/build/buildbotcustom/file/9a587b917756/steps/unittest.py#l455

Bug 506042 fixed the make target we use for unpacked unit tests.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Passes --symbols_path to runxpcshelltests.py

Do you need me to test this on staging?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #1)
> Do you need me to test this on staging?

Definitely. I suspect a command of format
 woo.py --foo=bar path_arg --jim=bob
is sufficiently unconventional to make OptionParser barf.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Passes --symbols_path to runxpcshelltests.py

I'll test this one on staging

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 398480 [details] [diff] [review]
Passes --symbols_path to runxpcshelltests.py

>+                self.command.append("""--manifest=xpcshell/tests/all-test-dirs.list %(exedir)s/xpcshell""".replace("\n", " && "))

This probably needs to be in a WithProperties wrapper

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Passes --symbols_path to runxpcshelltests.py

Tested on staging-master2, successfully added --symbols_path to the bash command

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 402426 [details] [diff] [review]
Passes --symbols_path to runxpcshelltests.py

http://hg.mozilla.org/build/buildbotcustom/rev/e1fb4b86b0bb