51261 - document.addBinding is broken

Status: RESOLVED WONTFIX

(Core :: XBL, defect)

Comment 1

[Peter Trudelle]

mass-moving xbl1.0 bugs to future, adding helpwanted keyword

Comment 2

[Aaron Leventhal]

This would help accessibility become an additive feature that doesn't affect
performance when it's not needed.

Comment 3

[Aaron Leventhal]

No longer needed for accessibility, since we are getting events through
WindowRoot now.

Comment 4

[Peter Trudelle]

->moz0.9

Comment 5

[Peter Trudelle]

->future

Comment 6

[Brendan Eich [:brendan]]

Hyatt says this requires prototype forking.

/be

Comment 7

[Alex Vincent [:WeirdAl]]

document.addBinding() is crash-happy.

Talkback ID TB17268969X.  Testcase included in talkback report.

Comment 8

[David Bradley]

Attachment: Stack of TB 17268969

Comment 9

[Alex Vincent [:WeirdAl]]

Attachment: Testcase (part 1 of 3)

Comment 10

[Alex Vincent [:WeirdAl]]

Attachment: Testcase (part 2 of 3, CSS stylesheet, unused)

Comment 11

[Alex Vincent [:WeirdAl]]

Attachment: Testcase zipped up (local files)

Couldn't reproduce the crash using first two attachments of testcase downloaded
from b.m.o.  Here's the same testcase using local files, zipped up into one
package.

Comment 12

[David Bradley]

Attachment: Stack of TB 17268969

Comment 13

[Alex Vincent [:WeirdAl]]

Regarding the crash bug, I tested the same @ home against Mozilla 1.0.  No crash
there, but I'd appreciate independent confirmation of that.

Comment 14

[Maksim Likharev]

Attachment: this one from me, addBinding, crash

xbl, latest mozilla, crash

Comment 15

[José Jeria]

No crash with Gecko/20030827 Mozilla Firebird/0.6.1+, testcase in comment 14

Comment 16

[Kevin Berkheiser]

No crash with testcase from comment 14.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040316

Comment 17

[Teresa Matthews]

Hi . . . Have been setting up firefox as recommended by Kim Komando.
Moved bookmarks . . . all working beautifully UNTIL I downloaded some themes.

One of them went crazy and now I keep getting an XBL binding message and I can 
not even load Firefox.  Have uninstalled all of Firefox and reloaded a fresh 
copy twice.  Still get the message so the themes have completely crippled my 
access to Firefox.

Is there something I can do  ?

Thank you.

Comment 18

[Teresa Matthews]

Hi . . . Have been setting up firefox as recommended by Kim Komando.
Moved bookmarks . . . all working beautifully UNTIL I downloaded some themes.

One of them went crazy and now I keep getting an XBL binding message and I can 
not even load Firefox.  Have uninstalled all of Firefox and reloaded a fresh 
copy twice.  Still get the message so the themes have completely crippled my 
access to Firefox.

Is there something I can do  ?

Thank you.

Comment 19

[Anne (:annevk)]

Attachment: binding

Comment 20

[Anne (:annevk)]

Attachment: testcase #1

It seems this is not supported at all...

Comment 21

[Alex Vincent [:WeirdAl]]

Reducing severity as document.addBinding is no longer crash-happy.

Comment 22

[Andreas Wuest]

(In reply to comment #21)

> Reducing severity as document.addBinding is no longer crash-happy.

Negative. For me, it keeps crashing every time it is called. This on Linux x86
with cvs checkout from some hours ago.

Sorry for the bad news.

Comment 23

[Boris Zbarsky [:bzbarsky]]

Andreas, could you please file a separate bug on the issue you're seeing (which
sounds like a regression)?  Please make sure to post a testcase that shows the
problem, and please CC me on the bug.

Comment 24

[Andreas Wuest]

(In reply to comment #23)

> Andreas, could you please file a separate bug on the issue you're seeing (which
> sounds like a regression)?  Please make sure to post a testcase that shows the
> problem, and please CC me on the bug.

Done. https://bugzilla.mozilla.org/show_bug.cgi?id=296375.

Comment 25

[Wladimir Palant]

Is my understanding correct that document.addBinding currently cannot be used at all? It only seems to work if document.loadBindingDocument has been called before, to the extent that the constructor executes and the anonymous nodes appear in DOM Inspector. For some reason these anonymous nodes can't be seen on the web page however. Did I miss some work-around?

Comment 26

[Wladimir Palant]

Found the workaround already: set .style.display="none" on the element, insert it into the document, call document.loadBindingDocument+document.addBinding, and finally set .style.display="" in the XBL constructor. Changing the display property forces a reflow which seems to be enough for the binding to display correctly.

Sorry about the bugspam.

Comment 27

[Brian Grinstead [:bgrins]]

XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so I'm closing bugs related to the implementation.