512690 - Fix prefcalls.js in autoconfig code for latest LDAP API changes.

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

The LDAP XPCOM code (that now exists in comm-central) changed its method of constructing urls to require the IO Service. prefcalls.js in the autoconfig pref code needs to do the same.

(note although there is a potential issue as to where the autoconfig ldap code should reside, we're just patching it up the best we can at the moment and will reconsider the future after TB 3 at some stage).

Attached patch fixes prefcalls.js for LDAP users. extensions/pref seems unowned, so I'm nominating bienvenu for the review as he has done some in there before and also knows some of the LDAP code.

Comment 1

[David :Bienvenu]

Comment on attachment 396718 [details] [diff] [review]
The fix

this looks reasonable - I'm not really setup to test it, but I think Jehan will be very happy to test it.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> (From update of attachment 396718 [details] [diff] [review])
> this looks reasonable - I'm not really setup to test it, but I think Jehan will
> be very happy to test it.

I forgot to mention, Jehan's already tested it - see bug 502597 comment 20.

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/5a6c87f83039

I'll leave this baking on trunk for a day or so before requesting approval.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 396718 [details] [diff] [review]
The fix

Requesting branch approvals. Low impact patch as this fixes LDAP autoconfig against the latest interfaces.

Firefox doesn't support LDAP autoconfig by default, SeaMonkey and Thunderbird do, so we want this on the branches especially as we know we have some reasonable size deployments using autoconfig.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 396718 [details] [diff] [review]
The fix

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 6

[Mark Banner (:standard8)]

Checked into 1.9.1.4: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/026a5331f77b

Comment 7

[Mark Banner (:standard8)]

Checked into 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/89fc533af6b0

Comment 8

[Al Billings [:abillings - ex-MoCo]]

I'm assuming not but is there a manual way to verify this fix? I don't have access to LDAP that is offering autoconfig.

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> I'm assuming not but is there a manual way to verify this fix? I don't have
> access to LDAP that is offering autoconfig.

Firefox doesn't allow autoconfig + LDAP at the moment anyway. For Thunderbird, from the comments on bug 502597 you can probably say it is fixed on 1.9.1 at least and then do code/checkin inspection for 1.9.2