512702 - [Classic, Win] File button in MailNews Search Messages window is too tall due to dropmarker height

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Search Messages window with File button focussed

The File button in the MailNews Search Messages window is too tall (the other buttons are OK) with the default theme. I tracked it down to the dropmarker the height of which seems to be wrong.

I guess the dropmarker default height defined in winstripe's dropmarker.css (16px) needs an override of some kind here or is completely wrong (Modern's dropmarker.css does not define the height and neither do the other *stripe dropmarker.css files). I'm not a theme expert, though, so I don't know where that override would need to be placed.

Counter example: The dropmarkers in the MailNews toolbar do not negatively affect the height of the outer toolbarbutton, even when only using small icons and no text. The difference between the two is that the File button receives extra styling from .button-menu-dropmarker, .button-menubutton-dropmarker (buttons.css) while the toolbar buttons receives it from .toolbarbutton-menubutton-dropmarker (toolbarbutton.css).

I'd really like to see this fixed for 2.0 because I think it looks dead ugly.

Screenshot (WinXP, default theme) attached.

The button looks OK in SM 1.1.17 with the Classic theme -> regression.

Note: This might be a general issue, it's only that I found it in Search Messages.

Comment 1

[Philip Chee]

See Toolkit Bug 375930 (dropmarker too small on windows) fixed on  2007-03-31.

Adding the following to searchDialog.css works but perhaps we should put it somewhere more general?

dropmarker {
  height: auto;
  width: auto;
}

Comment 2

[Philip Chee]

Attachment: Patch v1.0 Fix bogus dropmarker CSS.

Override the bogus rules in *stripe global/dropmarker.css introduced in Bug 375930.

Comment 3

[[e-mail]]

Attachment: Possible patch

Let's try fixing this regression at source.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 398356 [details] [diff] [review]
Patch v1.0 Fix bogus dropmarker CSS.

Fine with me either way. In case the Toolkit patch doesn't make mozilla-1.9.1 you may consider adopting the 11px value and adding a comment that this fix is only needed temporarily.

Note: I only checked the File button.

Comment 5

[[e-mail]]

Pushed changeset 05434d7dfd53 to mozilla-central.

Comment 6

[[e-mail]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

We'd appreciate it if you can take this safe regression fix on the 1.9.1 branch where Thunderbird 3.0 and SeaMonkey 2.0 can benefit from it. (Firefox doesn't use this particular feature which is why the bug went undetected.)

Comment 7

[Daniel Veditz [:dveditz]]

Not blocking, but we'll still look at the approval request.

I assume attachment 398374 [details] [diff] [review] is obsolete? We should mark it so rather than leave the review requests hanging out there.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 9

[[e-mail]]

Pushed changeset 1afb366f02ff to releases/mozilla-1.9.1

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.1 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090930 SeaMonkey/2.0pre.

Comment 11

[[e-mail]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

Regression for fix in documented feature.

Comment 12

[[e-mail]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

I must need sleep...

Comment 13

[[e-mail]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

Fix for regression in documented feature.

Comment 14

[[e-mail]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

Pushing approval request to the next branch release.

These changes do not affect Firefox, although they may improve the appearance of some Firefox extensions.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 398374 [details] [diff] [review]
Possible patch

Approved for 1.9.2.2, a=dveditz

Comment 16

[[e-mail]]

Pushed changeset f27b664528b4 to releases/mozilla-1.9.2

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100317 SeaMonkey/2.0.4