512811 - React to tab controller parameter change in bug 500506

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

The order of the parameters of the tab controller will be changed with bug 500506. We need to fix this in lightning code. Should be a trivial fix but needs to be done.

Comment 1

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

This needs to be fixed for 1.0, but probably not for the beta.

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

This should be fixed for beta!

Comment 3

[Karsten Düsterloh]

Comment on attachment 399036 [details] [diff] [review]
Patch v1

>+      supportsCommand: function (aCommand, aTab) calendarController.supportsCommand(aCommand),
>+      isCommandEnabled: function (aCommand, aTab) calendarController.isCommandEnabled(aCommand),
>+      doCommand: function(aCommand, aTab) calendarController.doCommand(aCommand),
>+      onEvent: function(aEvent, aTab) calendarController.onEvent(aEvent)

You should probably just derive the containing tab object from calendarController, compare <http://mxr.mozilla.org/comm-central/source/suite/mailnews/tabmail.js?mark=554#547>.

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 399036 [details] [diff] [review]
Patch v1


>+      supportsCommand: function (aCommand, aTab) calendarController.supportsCommand(aCommand),
>+      isCommandEnabled: function (aCommand, aTab) calendarController.isCommandEnabled(aCommand),
>+      doCommand: function(aCommand, aTab) calendarController.doCommand(aCommand),
>+      onEvent: function(aEvent, aTab) calendarController.onEvent(aEvent)

I wouldn't derive, since then we have a second controller instance and our controller does some operations we shouldn't have to do twice. This looks fine to me.


Aside from that, the TB code for this is post Tb3b3, so unless Tb3b4 is released before we release our b1, this shouldn't go into the beta.


r=philipp

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Aside from that, the TB code for this is post Tb3b3, so unless Tb3b4 is
> released before we release our b1, this shouldn't go into the beta.

If it is released before TB3 beta 4, then you probably want to ensure you limit lightning to just TB 3 beta 3.

If it is released after, then you want to ensure you limit lightning to TB 3 beta 4 and above...

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Ugh that of course sucks. In that case we probably want this for the beta. I was told b4 is targeted for the 22nd, which would fit quite good if we keep the plan. We should increase the minVersion to b4pre in that case.

Comment 7

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d928fb5c581f> (including increase of minVersion to 3.0b4pre)

-> FIXED

Comment 8

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".