stat of individual files in the components dir is unecessary

RESOLVED FIXED

Status

()

defect
P1
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dietrich, Assigned: benedict)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ts])

per the comments on bug 511761, the stat checks of individual component files in the components dir are unnecessary, because at application update, the only time those files would change, we invalidate the fastload cache. the stat calls should be removed.
Could we maybe leave the stat calls in for debug builds? It really does slow things down if you have to rebuild in more than one directory or manually touch some obscure file every time you make changes to the js files you're developing.
(In reply to comment #1)
> Could we maybe leave the stat calls in for debug builds? It really does slow
> things down if you have to rebuild in more than one directory or manually touch
> some obscure file every time you make changes to the js files you're
> developing.

i haven't looked through the code yet, but if it's as easy as ifdef debug, then certainly will do this.
OS: Mac OS X → All
Hardware: x86 → All
Priority: -- → P1
Whiteboard: [ts]
set a breakpoint in xptiInterfaceInfoManager::BuildFileList, that function should not be called during normal startup. Basically disable component invalidation checks to start with.
some related work in bug 511761, making this depend on that. not duping, to ensure this case is covered.
Depends on: 511761
Assignee: nobody → bhsieh
Should be fixed by bug 511761 and bug 510991.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.