Closed Bug 512853 Opened 16 years ago Closed 16 years ago

fix parseKeyValuePairs to support values containing =, use iframe type="content" for the about:crashes submit form

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed
status1.9.1 --- .4-fixed

People

(Reporter: ted, Assigned: ted)

References

(
URL
)

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

fix both issues
2.39 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Currently we use string.split('=',2), which apparently truncates if it encounters more than 1 =. We should fix that.
Summary: fix parseKeyValuePairs to support values containing = → fix parseKeyValuePairs to support values containing =, use iframe type="content" for the about:crashes submit form
Attached patch fix both issues — — Splinter Review
Fixes both issues, add a test for the "data containing =" case.
Attachment #397837 - Flags: review?(dtownsend)
Attachment #397837 - Flags: review?(dtownsend) → review+
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/5d7792125ab4
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified fixed for 1.9.1 in source.
Keywords: verified1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: