misc hydra fixes for callgraph work

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
8 months ago

People

(Reporter: dwitte, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 396947 [details] [diff] [review]
patch v1

This rolls up a bunch of fixes.

* make hasDefaults property work (bug 510212)
* add resolve_path() utility function for resolving symlinks (to be removed later)
* add/tweak some macro stuff in gcc_compat.js
* fix type_string() to work with ptr-to-members and C++/C code in our tree, to order qualifiers (const etc) more consistently with g++, to work with vectors, and consistently throw if it gets confused - so we can spot errors easier. (I'm basically relying on this function being sane for serializing callgraph method types.)
* random fix to dehydra_attachClassStuff() to make it not die on classes with no bases
* tests to tickle most codepaths in type_string()
Attachment #396947 - Flags: review?(tglek)
(Reporter)

Comment 1

9 years ago
Er, wrong component. ;)
Component: DOM: Abstract Schemas → Rewriting and Analysis
QA Contact: general → rewriting-and-analysis

Comment 2

9 years ago
Comment on attachment 396947 [details] [diff] [review]
patch v1


>+function DECL_IS_BUILTIN(decl) {
>+  return DECL_SOURCE_LOCATION(decl).line == 0;
>+}

that's so not what tree.h does. These should be identical to gcc, otherwise it gets tricky to debug what's going wrong.

Seems ok otherwise, r+ with above fixed.
Attachment #396947 - Flags: review?(tglek) → review+
(Reporter)

Comment 3

9 years ago
Oh, does gcc/g++ #define USE_MAPPED_LOCATION?
(Reporter)

Comment 4

9 years ago
http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/6308679eb663
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/0485f8c977ea

resolve_path made a js string the wrong way

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.