Don't expose empty live attribute if there is no aria-live and ARIA role hasn't default live value

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access, regression, verified1.9.2})

unspecified
access, regression, verified1.9.2
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

8.21 KB, patch
MarcoZ
: review+
davidb
: review+
Benjamin Smedberg
: approval1.9.2+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 396972 [details] [diff] [review]
patch

Don't expose empty live attribute if there is no aria-live and ARIA role hasn't default live value
Attachment #396972 - Flags: review?(marco.zehe)
Attachment #396972 - Flags: review?(bolterbugz)

Comment 1

9 years ago
Comment on attachment 396972 [details] [diff] [review]
patch

Thanks! r=me
Attachment #396972 - Flags: review?(marco.zehe) → review+

Comment 2

9 years ago
Comment on attachment 396972 [details] [diff] [review]
patch

Oops, forgot tow nits:
>+  // Check if all obtained attributes are expected and has expected value.

"... and have expected value"

>+  // Check if all unexpected attribute are absent.

"Check if all unexpected attributes are absent", attributes must be plural here.
(Assignee)

Comment 3

9 years ago
thanks, fixed locally
Comment on attachment 396972 [details] [diff] [review]
patch

r=me
Attachment #396972 - Flags: review?(bolterbugz) → review+
(Assignee)

Comment 5

9 years ago
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/b1e0a654f2bf
Blocks: 463645
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Keywords: regression
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #396972 - Flags: approval1.9.2?

Updated

9 years ago
Attachment #396972 - Flags: approval1.9.2? → approval1.9.2+
(Assignee)

Updated

9 years ago
status1.9.2: --- → beta1-fixed

Comment 7

9 years ago
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20090922 Namoroka/3.6b1pre (.NET CLR 3.5.30729)
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.