51306 - crash selecting local folder after compacting it

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[David :Bienvenu]

I compacted my local inbox, and then tried to open it - I crashed because the db
headers being held onto by the nsIMessage's were no longer valid. Not sure when
this was broken, or if it ever worked (but I'm guessing it must have worked).

Comment 1

[David :Bienvenu]

Is this because of the nsMessage recycler, Alec? In theory, we should be getting
rid of all the old message resources in this case, because they're all invalid
(the msg keys change when we compact). But I suspect that before, they just hung
around. Is there an easy way in RDF to get rid of a bunch of resources? Or, I
guess I could enumerate over the nsMessage's and clear out their nsIMsgDBHdr
pointers before blowing away the old db.

Comment 2

[Alec Flett]

I really don't think so - I didn't change the lifetime of the nsMessage objects 
or anything yet.. the only thing that HAS changed is the way the messagetype is 
set - and I think that only affected the RDF display of the message

Comment 3

[selmer (gone)]

nsbeta3+, P1.

Comment 4

[scottputterman]

yeah, I don't think we are recycling yet. But it's a good point that when we do 
recycle we should remember to remove the ref to the msghdr and to the folder.

Comment 5

[Alec Flett]

right, we're not recycling yet

Comment 6

[Phil Peterson]

PDT agrees P1

Comment 7

[David :Bienvenu]

this is happening because we're leaking nsMsgHdrs (or, really, because the
nsXULDocument is leaking, and it's holding onto nsMsgHdrs.)

Comment 8

[David :Bienvenu]

fix checked in.

Comment 9

[fenella]

Linux (2000-09-11-08 M18)
Win32 (2000-09-11-08 M18)
Mac (2000-09-08-20 M18)
This problem has been fixed.