Remove "Manage Addons" from Preferences UI

RESOLVED FIXED in Firefox 18

Status

()

Firefox
Preferences
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: Dolske, Assigned: Javi Rueda)

Tracking

({useless-UI})

Trunk
Firefox 18
useless-UI
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [killthem])

Attachments

(4 attachments)

(Reporter)

Description

8 years ago
This was apparently added for discoverability, but just feels awkward, out-of-place, and takes up space.
(Reporter)

Updated

8 years ago
Whiteboard: [killthem]
I've been complaining about that forever. :P
It is handy if you unintentionally click the wrong item in Tools, but now I know that it exists, I'm too late.
Was added in bug 384956, for what it's worth.
I'm fine with removing it (never really thought it was all that valuable) though the Firefox 3 PRD and others might still want it.
https://wiki.mozilla.org/Firefox3/Product_Requirements_Document#P2

Comment 5

8 years ago
This thing is awkward, I'll give you that, but I'd rather it be replaced with something less awkward than removed outright, if at all possible.
For the personas integration in 3.6, the personas team actually requested making this link from preferences to the add-ons manager even more discoverable.

Updated

8 years ago
Keywords: useless-UI
Removing this UI would mean less chance of running into bug 400479
(Assignee)

Updated

5 years ago
QA Contact: leofigueres
(Assignee)

Updated

5 years ago
Assignee: nobody → leofigueres
QA Contact: leofigueres
(Assignee)

Updated

5 years ago
Summary: Remove "Manage Addons" from Preferences --> General → Remove "Manage Addons" from Preferences UI
(Assignee)

Comment 8

5 years ago
Working on the browser code.

What about mail (Thunderbird) client? http://mxr.mozilla.org/comm-central/search?string=showAddonsMgr
(Assignee)

Comment 9

5 years ago
Created attachment 654310 [details] [diff] [review]
Removing UI in mozilla-central

It removes useless UI from the general pane, its associated code and related strings.

It seems that Gavin was last reviewer for main.js file. No need to say that review could be re-assigned to another person :-)
Attachment #654310 - Flags: review?(gavin.sharp)
Attachment #654310 - Flags: ui-review?(ux-review)
(Assignee)

Comment 10

5 years ago
Created attachment 654317 [details]
Screenshot showing the general tab once Manage Add-ons groupbox has been removed

If it helps in order to review the UX.
Comment on attachment 654310 [details] [diff] [review]
Removing UI in mozilla-central

Review of attachment 654310 [details] [diff] [review]:
-----------------------------------------------------------------

We have more primary access points for add-on in the menu or in Firefox button, so review plus.
Attachment #654310 - Flags: ui-review?(ux-review) → ui-review+
Attachment #654310 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 12

5 years ago
Would it be fine to land this now while working on the patch for comm-central/mail?
(Assignee)

Comment 13

5 years ago
Created attachment 654802 [details] [diff] [review]
comm-central repository (/mail/) part

Same as mozilla-central but for Mail client.
Attachment #654802 - Flags: review?(bugmail)
(Assignee)

Comment 14

5 years ago
Created attachment 654804 [details]
Screenshot showing the group box that has been removed from the pane
Attachment #654804 - Flags: ui-review?(ux-review)
Comment on attachment 654802 [details] [diff] [review]
comm-central repository (/mail/) part

bwinton can review this and provide UX-review.
Attachment #654802 - Flags: review?(bugmail) → review?(bwinton)
Attachment #654804 - Flags: ui-review?(ux-review) → ui-review?(bwinton)
Attachment #654804 - Flags: ui-review?(bwinton)
Comment on attachment 654802 [details] [diff] [review]
comm-central repository (/mail/) part

ui-r=me, as per fang's comments.

And the code seems fine, so r=me, too.

Thanks,
Blake.
Attachment #654802 - Flags: ui-review+
Attachment #654802 - Flags: review?(bwinton)
Attachment #654802 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/39c8939683e8
https://hg.mozilla.org/comm-central/rev/03fa1aeed9e2
Target Milestone: --- → Firefox 18
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/39c8939683e8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This made it into tb17, but only into fx18. Do we mind? Given that this is just removal of strings, I'd not be overly concerned about uplifting this quickly for consistency.
How can we re-enable it? We removed it from the menus and can no longer manage the plugins with the latest Firefox ESR. Undoing the menu change would require to manually delete each users profile on each workstation as for some reason the menus are per-profile.
(In reply to Andreas van dem Helge from comment #20)
> manage the plugins with the latest Firefox ESR. Undoing the menu change
> would require to manually delete each users profile on each workstation as
> for some reason the menus are per-profile.

You can simply go to the Tools menu and open the add-ons manager via 'Add-ons' or by pressing Shift + Ctrl/Cmd + A.
You need to log in before you can comment on or make changes to this bug.