Last Comment Bug 513164 - Remove "Manage Addons" from Preferences UI
: Remove "Manage Addons" from Preferences UI
Status: RESOLVED FIXED
[killthem]
: useless-UI
Product: Firefox
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 18
Assigned To: Javi Rueda
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-27 18:24 PDT by Justin Dolske [:Dolske]
Modified: 2013-10-22 23:53 PDT (History)
23 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Removing UI in mozilla-central (5.08 KB, patch)
2012-08-22 12:15 PDT, Javi Rueda
gavin.sharp: review+
zfang: ui‑review+
Details | Diff | Splinter Review
Screenshot showing the general tab once Manage Add-ons groupbox has been removed (37.59 KB, image/png)
2012-08-22 12:29 PDT, Javi Rueda
no flags Details
comm-central repository (/mail/) part (3.35 KB, patch)
2012-08-23 14:48 PDT, Javi Rueda
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
Screenshot showing the group box that has been removed from the pane (41.72 KB, image/png)
2012-08-23 14:50 PDT, Javi Rueda
no flags Details

Description Justin Dolske [:Dolske] 2009-08-27 18:24:18 PDT
This was apparently added for discoverability, but just feels awkward, out-of-place, and takes up space.
Comment 1 Noah (oldtimer) [:Noah] 2009-08-27 21:08:28 PDT
I've been complaining about that forever. :P
Comment 2 Ria Klaassen (not reading all bugmail) 2009-08-28 01:34:59 PDT
It is handy if you unintentionally click the wrong item in Tools, but now I know that it exists, I'm too late.
Comment 3 :Gavin Sharp [email: gavin@gavinsharp.com] 2009-08-28 11:51:33 PDT
Was added in bug 384956, for what it's worth.
Comment 4 Robert Strong [:rstrong] (use needinfo to contact me) 2009-08-28 12:07:36 PDT
I'm fine with removing it (never really thought it was all that valuable) though the Firefox 3 PRD and others might still want it.
https://wiki.mozilla.org/Firefox3/Product_Requirements_Document#P2
Comment 5 Dave Garrett 2009-08-31 12:52:26 PDT
This thing is awkward, I'll give you that, but I'd rather it be replaced with something less awkward than removed outright, if at all possible.
Comment 6 Dão Gottwald [:dao] 2009-09-02 07:46:27 PDT
For the personas integration in 3.6, the personas team actually requested making this link from preferences to the add-ons manager even more discoverable.
Comment 7 Luke Iliffe (Harlequin99) 2009-10-22 12:03:38 PDT
Removing this UI would mean less chance of running into bug 400479
Comment 8 Javi Rueda 2012-08-22 02:52:55 PDT
Working on the browser code.

What about mail (Thunderbird) client? http://mxr.mozilla.org/comm-central/search?string=showAddonsMgr
Comment 9 Javi Rueda 2012-08-22 12:15:58 PDT
Created attachment 654310 [details] [diff] [review]
Removing UI in mozilla-central

It removes useless UI from the general pane, its associated code and related strings.

It seems that Gavin was last reviewer for main.js file. No need to say that review could be re-assigned to another person :-)
Comment 10 Javi Rueda 2012-08-22 12:29:57 PDT
Created attachment 654317 [details]
Screenshot showing the general tab once Manage Add-ons groupbox has been removed

If it helps in order to review the UX.
Comment 11 Zhenshuo Fang (:fang) - Firefox UX Team 2012-08-22 13:50:42 PDT
Comment on attachment 654310 [details] [diff] [review]
Removing UI in mozilla-central

Review of attachment 654310 [details] [diff] [review]:
-----------------------------------------------------------------

We have more primary access points for add-on in the menu or in Firefox button, so review plus.
Comment 12 Javi Rueda 2012-08-23 04:43:13 PDT
Would it be fine to land this now while working on the patch for comm-central/mail?
Comment 13 Javi Rueda 2012-08-23 14:48:30 PDT
Created attachment 654802 [details] [diff] [review]
comm-central repository (/mail/) part

Same as mozilla-central but for Mail client.
Comment 14 Javi Rueda 2012-08-23 14:50:51 PDT
Created attachment 654804 [details]
Screenshot showing the group box that has been removed from the pane
Comment 15 Andrew Sutherland [:asuth] 2012-08-23 17:35:02 PDT
Comment on attachment 654802 [details] [diff] [review]
comm-central repository (/mail/) part

bwinton can review this and provide UX-review.
Comment 16 Blake Winton (:bwinton) (:☕️) 2012-08-27 06:10:56 PDT
Comment on attachment 654802 [details] [diff] [review]
comm-central repository (/mail/) part

ui-r=me, as per fang's comments.

And the code seems fine, so r=me, too.

Thanks,
Blake.
Comment 18 Ryan VanderMeulen [:RyanVM] 2012-08-27 19:19:27 PDT
https://hg.mozilla.org/mozilla-central/rev/39c8939683e8
Comment 19 Axel Hecht [:Pike] 2012-08-29 05:50:38 PDT
This made it into tb17, but only into fx18. Do we mind? Given that this is just removal of strings, I'd not be overly concerned about uplifting this quickly for consistency.
Comment 20 Andreas van dem Helge 2013-10-22 23:42:12 PDT
How can we re-enable it? We removed it from the menus and can no longer manage the plugins with the latest Firefox ESR. Undoing the menu change would require to manually delete each users profile on each workstation as for some reason the menus are per-profile.
Comment 21 Henrik Skupin (:whimboo) 2013-10-22 23:53:21 PDT
(In reply to Andreas van dem Helge from comment #20)
> manage the plugins with the latest Firefox ESR. Undoing the menu change
> would require to manually delete each users profile on each workstation as
> for some reason the menus are per-profile.

You can simply go to the Tools menu and open the add-ons manager via 'Add-ons' or by pressing Shift + Ctrl/Cmd + A.

Note You need to log in before you can comment on or make changes to this bug.