513214 - 'Never Show' button in popup notification should be per-site, not global

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 397245 [details] [diff] [review]
Patch

>diff -r 54c827234898 chrome/content/browser.js

>+  toggleDenyPopupsForSite: function toggleDenyPopupsForSite(aEvent) {
>+    var currentURI = Browser.selectedBrowser.webNavigation.currentURI;

We use Browser.selectedBrowser.currentURI consistently everywhere else

>+    var pm = Cc["@mozilla.org/permissionmanager;1"].getService(this._kIPM);
>+    pm.add(currentURI, "popup", this._kIPM.DENY_ACTION);
>+
>     Browser.getNotificationBox().removeCurrentNotification();
>   },

This method doesn't "toggle" the setting. denyPopupsForSite is good enough

r+ with those changes

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Address comments

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/65a94d7346b7

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on build (via nypost.com and popuptest.com):

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090903 Fennec/1.0a3