513428 - JS_IsArrayObject should call js_GetWrappedObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

This is needed for more transparency in transparent wrappers.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

This also fixes Array.isArray().

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 397431 [details] [diff] [review]
Fix

Sure -- only thought is to make a js_IsArrayObject static inline helper in jsarray.h to common the OBJ_IS_ARRAY(cx, js_GetWrappedObject(cx, ...)).

/be

Comment 3

[Jeff Walden [:Waldo]]

Inline JSObject::isArray?

Comment 4

[Brendan Eich [:brendan]]

(In reply to comment #3)
> Inline JSObject::isArray?

Modularity wants it in jsarray.h, which includes jsobj.h and defines OBJ_IS_ARRAY and declares the extern JSClass instances. Does it work to declare an inline in JSObject in jsobj.h but define the same inline in jsarray.h, and files that never include jsarray.h and of course never call obj->isArray won't mind?

/be

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Is it worth it? Looking at other uses of OBJ_IS_ARRAY, these two appear to be unique.

Comment 6

[Jeff Walden [:Waldo]]

Hm, maybe not.  Replacing the non-unwrapping version is more interesting to me, and that's not really for here and now.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/64c10219c320

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/64c10219c320

Comment 9

[Robert Sayre]

blake, do we want this on 1.9.2?

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, I think we do.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 397431 [details] [diff] [review]
Fix

This makes wrappers more transparent and might fix bug 525736.

Comment 12

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Any chance this will make it to branch? If not I'll just work around it for bug 525736.

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I would argue that we want this no matter what. It breaks JSON-serialization of any array that is wrapped (or any object that contains such an array of course).

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/978fa137b516