513446 - Small icons in MailNews toolbar becomes large when customizing

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

STR (recent 1.9.1 "trunk", mac classic theme):

1) Open mailNews
2) Right-click on toolbar and set your icon size to small
3) Right-click on toolbar and choose "Customize..."

--> Icons in toolbar becomes large

Comment 1

[Philip Chee]

Attachment: Patch v1.0 [Checkin: Comment 6]

-toolbar[iconsize="small"] > #button-delete[disabled] {
+toolbar[iconsize="small"] > #button-delete[disabled],
+toolbar[iconsize="small"] > toolbarpaletteitem > #button-delete[disabled] {

-toolbar[iconsize="small"] > #button-junk[disabled="true"] {
+toolbar[iconsize="small"] > #button-junk[disabled],
+toolbar[iconsize="small"] > toolbarpaletteitem > #button-junk[disabled] {

Brain-dead toolkit code removes the [disabled] attribute from toolbarbuttons but not toolbaritems.

Comment 2

[[e-mail]]

Comment on attachment 398349 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 6]

This doesn't actually fix /mac/ though does it?

Comment 3

[Philip Chee]

> This doesn't actually fix /mac/ though does it?
I'm waiting for some of Stefans mac patches to land first.

Comment 4

[Stefan [:stefanh]]

Comment on attachment 398349 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 6]

I can't review this because I don't have a win/nix box.

Comment 5

[Philip Chee]

I'll leave this open until mac/classic is fixed.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 398349 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/fd2ad33962fa

Comment 7

[Philip Chee]

Attachment: Patch v1.0Mac Patch for Mac Classic (pushed)

>> This doesn't actually fix /mac/ though does it?
>> I'm waiting for some of Stefans mac patches to land first.

Stefans Mac Classic patches have landed. This patch applies on top of them.

Comment 8

[[e-mail]]

Comment on attachment 399422 [details] [diff] [review]
Patch v1.0Mac Patch for Mac Classic (pushed)

>-toolbar[iconsize="small"] > #button-junk > #junk-deck > .toolbarbutton-1 {
>+toolbar[iconsize="small"] > #button-junk,
:-)

Comment 9

[Ian Neal]

Comment on attachment 399422 [details] [diff] [review]
Patch v1.0Mac Patch for Mac Classic (pushed)

Looks fine but cannot test on a mac.

Comment 10

[Stefan [:stefanh]]

Comment on attachment 399422 [details] [diff] [review]
Patch v1.0Mac Patch for Mac Classic (pushed)

http://hg.mozilla.org/comm-central/rev/8fab1d83ac32