Closed Bug 513446 Opened 12 years ago Closed 12 years ago

Small icons in MailNews toolbar becomes large when customizing

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: stefanh, Assigned: philip.chee)

References

Details

(Keywords: classic, fixed-seamonkey2.0)

Attachments

(2 files)

STR (recent 1.9.1 "trunk", mac classic theme):

1) Open mailNews
2) Right-click on toolbar and set your icon size to small
3) Right-click on toolbar and choose "Customize..."

--> Icons in toolbar becomes large
Keywords: polish
Summary: Small icons in toolbar becomes large when customizing → Small icons in MailNews toolbar becomes large when customizing
-toolbar[iconsize="small"] > #button-delete[disabled] {
+toolbar[iconsize="small"] > #button-delete[disabled],
+toolbar[iconsize="small"] > toolbarpaletteitem > #button-delete[disabled] {

-toolbar[iconsize="small"] > #button-junk[disabled="true"] {
+toolbar[iconsize="small"] > #button-junk[disabled],
+toolbar[iconsize="small"] > toolbarpaletteitem > #button-junk[disabled] {

Brain-dead toolkit code removes the [disabled] attribute from toolbarbuttons but not toolbaritems.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #398349 - Flags: ui-review?(stefanh)
Attachment #398349 - Flags: superreview?(neil)
Attachment #398349 - Flags: review?(iann_bugzilla)
Comment on attachment 398349 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 6]

This doesn't actually fix /mac/ though does it?
Attachment #398349 - Flags: superreview?(neil) → superreview+
> This doesn't actually fix /mac/ though does it?
I'm waiting for some of Stefans mac patches to land first.
Comment on attachment 398349 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 6]

I can't review this because I don't have a win/nix box.
Attachment #398349 - Flags: ui-review?(stefanh)
Flags: blocking-seamonkey2.0?
Keywords: polish
Flags: blocking-seamonkey2.0? → blocking-seamonkey2.0+
Attachment #398349 - Flags: review?(iann_bugzilla) → review+
I'll leave this open until mac/classic is fixed.
Keywords: checkin-needed
Comment on attachment 398349 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/fd2ad33962fa
Attachment #398349 - Attachment description: Patch v1.0 → Patch v1.0 [Checkin: Comment 6]
>> This doesn't actually fix /mac/ though does it?
>> I'm waiting for some of Stefans mac patches to land first.

Stefans Mac Classic patches have landed. This patch applies on top of them.
Attachment #399422 - Flags: ui-review?(stefanh)
Attachment #399422 - Flags: superreview?(neil)
Attachment #399422 - Flags: review?(iann_bugzilla)
Attachment #399422 - Flags: superreview?(neil) → superreview+
Comment on attachment 399422 [details] [diff] [review]
Patch v1.0Mac Patch for Mac Classic (pushed)

>-toolbar[iconsize="small"] > #button-junk > #junk-deck > .toolbarbutton-1 {
>+toolbar[iconsize="small"] > #button-junk,
:-)
Attachment #399422 - Flags: ui-review?(stefanh) → ui-review+
Comment on attachment 399422 [details] [diff] [review]
Patch v1.0Mac Patch for Mac Classic (pushed)

Looks fine but cannot test on a mac.
Attachment #399422 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 399422 [details] [diff] [review]
Patch v1.0Mac Patch for Mac Classic (pushed)

http://hg.mozilla.org/comm-central/rev/8fab1d83ac32
Attachment #399422 - Attachment description: Patch v1.0Mac Patch for Mac Classic → Patch v1.0Mac Patch for Mac Classic (pushed)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
You need to log in before you can comment on or make changes to this bug.