Closed
Bug 513560
Opened 15 years ago
Closed 15 years ago
mochitest-browser-chrome: intermittent "browser_passwordmgrdlg.js | Timed out"
Categories
(Toolkit :: Password Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta3-fixed |
People
(Reporter: sgautherie, Assigned: ehsan.akhgari)
References
(Depends on 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
7.70 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1251632618.1251638510.5559.gz Linux mozilla-central unit test on 2009/08/30 04:43:38 { Running chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js... TEST-UNEXPECTED-FAIL | ... | Timed out }
Comment 1•15 years ago
|
||
I don't think this is a dupe of bug 513560 but browser_passwordmgrdlg.js was changed in that bug, so worth a mention.
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > I don't think this is a dupe of bug 513560 but browser_passwordmgrdlg.js was > changed in that bug, so worth a mention. Bug 513560 is this bug, right?
Assignee | ||
Comment 3•15 years ago
|
||
This could be caused by browser_passwordmgr_sort.js finishing before the passwordmgr dialog has actually closed, and browser_passwordmgr.js timing out looking for a domwindowopened. In this fix, I also ported the focus handling rewrite changes to browser_passwordmgr_sort.js as well.
Comment 4•15 years ago
|
||
Comment on attachment 398877 [details] [diff] [review] Patch (v1) Unlucky you, Enn just blogged about what should be a better way to fix this: http://enndeakin.wordpress.com/2009/09/08/how-to-fix-focus-related-problems-in-tests/
Attachment #398877 -
Flags: review?(dolske) → review-
Comment 5•15 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1252904272.1252907789.17847.gz Linux mozilla-central test everythingelse on 2009/09/13 21:57:52
Assignee | ||
Comment 6•15 years ago
|
||
(In reply to comment #4) > (From update of attachment 398877 [details] [diff] [review]) > Unlucky you, Enn just blogged about what should be a better way to fix this: > > http://enndeakin.wordpress.com/2009/09/08/how-to-fix-focus-related-problems-in-tests/ I filed bug 516440 to port this to the browser chrome tests framework, so that I can use it here.
Comment 7•15 years ago
|
||
(In reply to comment #2) Oh yea, my mistake. I must have copied the wrong bug number... Maybe the one that you fixed before?
Comment 8•15 years ago
|
||
(happend on branch) http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1253719685.1253728275.32169.gz Linux mozilla-1.9.2 unit test on 2009/09/23 08:28:05
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1255645695.1255649616.21267.gz Linux mozilla-central test everythingelse on 2009/10/15 15:28:15 TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | Timed out and then a possibly-related error on shutdown: buildbot.slave.commands.TimeoutError: command timed out: 1200 seconds without output, killing pid 4625
Comment 10•15 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1257932979.1257938217.8708.gz Linux mozilla-central debug test everythingelse on 2009/11/11 01:49:39 s: moz2-linux-slave27
Assignee | ||
Comment 11•15 years ago
|
||
Switch to waitForFocus as well as the previous fix for waiting until the window is closed.
Attachment #398877 -
Attachment is obsolete: true
Attachment #411699 -
Flags: review?(dolske)
Comment 12•15 years ago
|
||
FYI, waitForFocus can be a bit finicky in browser-chrome tests. There's a fix checked in, but it doesn't always work. See bug 521233.
Assignee | ||
Comment 13•15 years ago
|
||
Thanks for mentioning this, I added that as a dependency on this bug, though actually the other part of the patch is what really solves this orange.
Updated•15 years ago
|
Attachment #411699 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 14•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5b8c9b073078
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Comment 15•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/beac3ae9eef0
status1.9.2:
--- → final-fixed
Reporter | ||
Updated•15 years ago
|
Attachment #411699 -
Attachment description: Patch (v2) → Patch (v2)
[Checkin: Comment 14 & 15]
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•