513560 - mochitest-browser-chrome: intermittent "browser_passwordmgrdlg.js | Timed out"

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1251632618.1251638510.5559.gz
Linux mozilla-central unit test on 2009/08/30 04:43:38
{
Running chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js...
TEST-UNEXPECTED-FAIL | ... | Timed out
}

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I don't think this is a dupe of bug 513560 but browser_passwordmgrdlg.js was changed in that bug, so worth a mention.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I don't think this is a dupe of bug 513560 but browser_passwordmgrdlg.js was
> changed in that bug, so worth a mention.

Bug 513560 is this bug, right?

Comment 3

[(no longer active)]

Attachment: Patch (v1)

This could be caused by browser_passwordmgr_sort.js finishing before the passwordmgr dialog has actually closed, and browser_passwordmgr.js timing out looking for a domwindowopened.

In this fix, I also ported the focus handling rewrite changes to browser_passwordmgr_sort.js as well.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 398877 [details] [diff] [review]
Patch (v1)

Unlucky you, Enn just blogged about what should be a better way to fix this:

http://enndeakin.wordpress.com/2009/09/08/how-to-fix-focus-related-problems-in-tests/

Comment 5

[Marco Bonardo [:mak]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1252904272.1252907789.17847.gz
Linux mozilla-central test everythingelse on 2009/09/13 21:57:52

Comment 6

[(no longer active)]

(In reply to comment #4)
> (From update of attachment 398877 [details] [diff] [review])
> Unlucky you, Enn just blogged about what should be a better way to fix this:
> 
> http://enndeakin.wordpress.com/2009/09/08/how-to-fix-focus-related-problems-in-tests/

I filed bug 516440 to port this to the browser chrome tests framework, so that I can use it here.

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #2)
Oh yea, my mistake. I must have copied the wrong bug number... Maybe the one that you fixed before?

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

(happend on branch)
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1253719685.1253728275.32169.gz
Linux mozilla-1.9.2 unit test on 2009/09/23 08:28:05

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1255645695.1255649616.21267.gz
Linux mozilla-central test everythingelse on 2009/10/15 15:28:15  
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | Timed out

and then a possibly-related error on shutdown:

buildbot.slave.commands.TimeoutError: command timed out: 1200 seconds without output, killing pid 4625

Comment 10

[(not currently active) Ted Mielczarek]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1257932979.1257938217.8708.gz
Linux mozilla-central debug test everythingelse on 2009/11/11 01:49:39  
s: moz2-linux-slave27

Comment 11

[(no longer active)]

Attachment: Patch (v2) [Checkin: Comment 14 & 15]

Switch to waitForFocus as well as the previous fix for waiting until the window is closed.

Comment 12

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

FYI, waitForFocus can be a bit finicky in browser-chrome tests. There's a fix checked in, but it doesn't always work. See bug 521233.

Comment 13

[(no longer active)]

Thanks for mentioning this, I added that as a dependency on this bug, though actually the other part of the patch is what really solves this orange.

Comment 14

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/5b8c9b073078

Comment 15

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/beac3ae9eef0