Closed
Bug 513647
Opened 17 years ago
Closed 17 years ago
Warning on the override of nsXHTMLContentSerializer::SerializeAttributes
Categories
(Core :: DOM: Serializers, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: laurent, Assigned: laurent)
Details
Attachments
(1 file)
|
2.60 KB,
patch
|
smaug
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Boris found a warning in the serializer https://bugzilla.mozilla.org/show_bug.cgi?id=422403#c42
SerializeAttributes has not the same signature in nsXHTMLContentSerializer and in nsHTMLContentSerializer, and in fact, there is no reason to use the same name. Using a different name would avoid the warning.
|
Assignee | |
Comment 1•17 years ago
|
||
I renamed the method.
Attachment #397586 -
Flags: superreview?(bzbarsky)
Attachment #397586 -
Flags: review?(Olli.Pettay)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 397586 [details] [diff] [review]
The patch
Please fix the argument indentation, and looks good.
Attachment #397586 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Updated•17 years ago
|
Attachment #397586 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
I pushed the patch, with fixed indentation.
http://hg.mozilla.org/mozilla-central/rev/c2843401d2f9
Flags: wanted1.9.2?
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•