513741 - "ASSERTION: rule walker must be at root" with XBL, rem unit, display:table

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: rule walker must be at root: 'mRuleWalker->AtRoot()', file /Users/jruderman/central/layout/style/nsStyleSet.cpp, line 691

This assertion was added in bug 507457 comment 10.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: stack showing problem

I'm not sure what we ought to do about this.

We could just make GetContext reset the rule walker before calling NS_NewStyleContext.

Or we could make the rule walker not be a member of the style set at all; that would either change the bug 492675 / bug 466024 crashes into something else or fix them.

I'm sort of tempted to just do the latter; I was tempted to do it when fixing bug 507457.

Thoughts?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Here's the simple patch.

It's possible this also fixes bug 466024.

I also threw in a signed-vs.-unsigned-comparison warning fix.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/320f3de0b43f

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #2)
> It's possible this also fixes bug 466024.

... and bug 492675; they're really the same thing, and I forget to mention both sometimes.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Actually, I take that back; I don't think this will fix a crash in FileRules or AddImportantRules.