Closed
Bug 513758
Opened 16 years ago
Closed 14 years ago
Pressing Pos1/End key while video is in ended state sets status to play
Categories
(Toolkit :: Video/Audio Controls, defect)
Toolkit
Video/Audio Controls
Tracking
()
VERIFIED
FIXED
mozilla10
People
(Reporter: whimboo, Assigned: padenot)
References
()
Details
Attachments
(2 files)
1.48 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
1.49 KB,
patch
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090831 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20090831044843
Pressing the end key when the video has ended switches the playback state to play for a split of a second. That shouldn't happen. There should no reaction for that key.
Reporter | ||
Comment 1•16 years ago
|
||
Same applies to the Pos1 key. When you hit it while you are in the ended state the position is set to zero and the video starts playing.
Summary: Pressing End key sets playback status to play for a split of second → Pressing Pos1/End key while video is in ended state sets status to play
Updated•16 years ago
|
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Version: Trunk → unspecified
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 2•14 years ago
|
||
Here is a patch that fix the behavior described in the comment 1.
I think the behavior described in comment 2 is normal, since most of the time, when someone rewinds a video, it's to watch it again.
Attachment #552380 -
Flags: review?(dolske)
Updated•14 years ago
|
Attachment #552380 -
Flags: review?(dolske) → review+
Comment 3•14 years ago
|
||
Pushed to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/75692b1af68f
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
Comment 4•14 years ago
|
||
I converted tabs to spaces, fixed it to use 4-space indentation (consistency) and removed the curly braces since they were unnecessary and inconsistent with the file.
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla10
Comment 6•14 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Windows NT 5.1; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0
Verified the fix on the above environments: pressing END key when video ended doesn't trigger any action (nothing happens).
Pressing HOME will play the video again and pressing END while video is playing sets the timer to the end of the video (video ends). Please confirm that this behaviour is intended before setting the bug as VEERIFIED.
Thank you!
Comment 7•14 years ago
|
||
(In reply to Mihaela Velimiroviciu [QA] from comment #6)
> Pressing HOME will play the video again and pressing END while video is
> playing sets the timer to the end of the video (video ends). Please confirm
> that this behaviour is intended before setting the bug as VEERIFIED.
> Thank you!
Yes, this is intended. Thank you :)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•