TM: fix incorrect ARGSIZE_LO usages on x64

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: dvander, Unassigned)

Tracking

unspecified
x86
Mac OS X
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Created attachment 397729 [details] [diff] [review]
patch

There are a few places we should be using ARGSIZE_P instead.
Attachment #397729 - Flags: review?(jorendorff)
Comment on attachment 397729 [details] [diff] [review]
patch

Nanojit now offers nicer ARGSIZE_ constants than when I originally wrote this.

So please instead change it like this:

>#define _JS_I32_ARGSIZE    nanojit::ARGSIZE_I
>#define _JS_I32_RETSIZE    nanojit::ARGSIZE_I
>#define _JS_F64_ARGSIZE    nanojit::ARGSIZE_Q
>#define _JS_F64_RETSIZE    nanojit::ARGSIZE_Q
>#define _JS_PTR_ARGSIZE    nanojit::ARGSIZE_P
>#define _JS_PTR_RETSIZE    nanojit::ARGSIZE_P

For bonus points remove the bogus distinction between ARGSIZE and RETSIZE. It looks like it's no longer needed.

r=me with that.
Attachment #397729 - Flags: review?(jorendorff) → review+
Actually ... for that matter, we shouldn't use ARGSIZE_LO anywhere. Please change the remaining few to ARGSIZE_I.
http://hg.mozilla.org/mozilla-central/rev/b4d46d7b59cc
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a0f1ac4a526e
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.