513804 - Disable Java in 1.6.x for users on 10.6, and clean up after the mess it created in 2.x

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Per irc, we're going to disable Java entirely for users on 10.6, since the JEP there is incompatible with Java on 10.6 (bug 512834) *and* the compatible JEP is 10.4+.

For users on 10.3.9 to 10.5.8, there will be no change.

For users on 10.6:

* 1.6 sets a new force-off pref to true on 10.6, sets the real pref to false
* The pref pane will disable the checkbox if the force-off pref is set
* On 1.6, you'd have to manually change the force-off pref to change the real pref (i.e., in order to set the UI to on)
* We won't set the force-off at all if Java is already off so we don't enable Java for pink
* Each new release (e.g. 1.6.11) needs to reset the force-off pref again, since that release will replace a user's custom-installed good JEP with a bad one again

* 2.0 will turn the real pref on it the force-off pref is set
* (and delete the force-off)
* And it won't handle moving back and forth

Comment 1

[Stuart Morgan]

Before I forget:
> * The pref pane will disable the checkbox if the force-off pref is set
I realized later that this isn't quite right; it will be disabled unless the force-off pref is set to false. Not having it at all will be equivalent to having it set to true for this case (but we need to distinguish between "forced off" and "was already off" for the pink upgrade case, as mentioned in comment 0).

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've written up a support wiki document for this (and included the link in the draft relnotes); we'll need to update it with whatever pref name we choose (and with any details I've missed):

http://wiki.caminobrowser.org/QA:Camino_1.6.x%2C_Mac_OS_X_10.6%2C_and_Java

Comment 3

[Stuart Morgan]

(In reply to comment #1)
> Not having it at all will be

... impossible, because then about:config won't work. But we don't want to make people use user.js, because then we can't reset it for later 1.6.x's if necessary. Doh.

I guess we'll need a second new pref to track the initial state of Java.

Comment 4

[Stuart Morgan]

Attachment: Branch fix

This reads the JEP version, so users won't have to muck with hidden prefs--as soon as they launch with a valid version of the JEP, then Java will go back to the way it was. On update, when the old version is back, it will disable again.

I don't do any kind of strict version checking on the JEP version; my feeling is that if someone goes out of their way to manually install an obsolete version of the JEP, they get what they deserve.

Comment 5

[Stuart Morgan]

Attachment: Trunk cleanup

This is the trunk cleanup, so when people update to 2.0 everything will go back to the way it was.

I've tested several cycles between 1.6.x, 1.6.x+new JEP, and 2.0 with these changes, with Java starting both on and off, and everything came out right, so this should be seamless for users (except for Java not working in 1.6.10 on 10.6 of course, but at least it won't crash).

Comment 6

[Stuart Morgan]

I've updated the wiki page in comment 2 to remove the part about changing prefs.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 401767 [details] [diff] [review]
Branch fix

>Index: PreferencePanes/WebFeatures/English.lproj/Localizable.strings.in
>===================================================================

>+"JavaSuppressionExplanation" = "Camino's Java plugin is not compatible with Mac OS X 10.6. To learn more, visit the FAQ section of Camino Help";

Please use the typographical apostrophe, and please end the second sentence with a period.  Also, Camino style is "plug-in", not "plugin".

The string should instead read

"JavaSuppressionExplanation" = "Camino’s Java plug-in is not compatible with Mac OS X 10.6. To learn more, visit the FAQ section of Camino Help.";

Comment 8

[Stuart Morgan]

Attachment: Branch fix v2

Corrected localized string.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 401768 [details] [diff] [review]
Trunk cleanup

sr=pink

Comment 10

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 401783 [details] [diff] [review]
Branch fix v2

sr=pink

Comment 11

[Stuart Morgan]

Landed branch fix on MOZILLA_1_8_BRANCH and trunk cleanup on CVS trunk and CAMINO_2_0_BRANCH.