513858 - Inverse themes (light text on dark backgrounds) breaks theme

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The Fennec theme is designed in a way that works with dark-on-light widgets. Unfortunately, we do not explicitly cover all widgets, so switching to a light-on-dark OS theme can break aspects of the Fennec UI (and web content too).

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch (web content)

This patch adjusts the web content widgets to always prefer a dark-on-light scheme

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed the web content patch: https://hg.mozilla.org/mobile-browser/rev/576044d22577

I added some disabled states before landing

Leaving open for the chrome patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch (chrome content)

Patch for the chrome UI. With this patch in place, I don't see any inverse color scheme affecting the chrome UI.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed chrome patch:
https://hg.mozilla.org/mobile-browser/rev/2af887408256

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

how can I verify this bug?  Any specific chrome bits?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Use an inverted theme on Linux or use an N900. Look at the bookmarks, add-ons or download lists. They used to have a black background