Closed Bug 513858 Opened 11 years ago Closed 11 years ago

Inverse themes (light text on dark backgrounds) breaks theme

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(2 files)

The Fennec theme is designed in a way that works with dark-on-light widgets. Unfortunately, we do not explicitly cover all widgets, so switching to a light-on-dark OS theme can break aspects of the Fennec UI (and web content too).
This patch adjusts the web content widgets to always prefer a dark-on-light scheme
Assignee: nobody → mark.finkle
Attachment #397806 - Flags: review?(pavlov)
Attachment #397806 - Flags: review?(pavlov) → review+
pushed the web content patch: https://hg.mozilla.org/mobile-browser/rev/576044d22577

I added some disabled states before landing

Leaving open for the chrome patch
Patch for the chrome UI. With this patch in place, I don't see any inverse color scheme affecting the chrome UI.
Attachment #398077 - Flags: review?(pavlov)
Attachment #398077 - Flags: review?(pavlov) → review+
pushed chrome patch:
https://hg.mozilla.org/mobile-browser/rev/2af887408256
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
how can I verify this bug?  Any specific chrome bits?
Use an inverted theme on Linux or use an N900. Look at the bookmarks, add-ons or download lists. They used to have a black background
You need to log in before you can comment on or make changes to this bug.