513891 - Move filefield rules to global/

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[[e-mail]]

Bug 459372 moved the filefield rules to global/ for the Classic theme, however we still have an obsolete copy (assuming we prefer toolkit theming) and we also need to move the rules for the Modern theme into a new filefield.css file.

CCing stefanh to confirm that we want pinstripe filefield theming.

Comment 1

[Stefan [:stefanh]]

Sure, I'm ok with pinstripe filefield theming.

Comment 2

[Stefan [:stefanh]]

Actually, I'll lose the opacity rule - but I could add that to the toolkit file. No big deal, I guess.

Comment 3

[Stefan [:stefanh]]

Attachment: Move filefield css

I used hg copy for modern and since IanN added the filefield code I kept only him as a contributor.

Comment 4

[Stefan [:stefanh]]

(In reply to comment #2)
> Actually, I'll lose the opacity rule - but I could add that to the toolkit
> file. No big deal, I guess.

Especially since we don't have any icon on mac - I guess it's because we don't have any shell service for mac.

Comment 5

[[e-mail]]

Comment on attachment 398228 [details] [diff] [review]
Move filefield css

>-/* File Field Widget */
> filefield {
Nit: the toolkit fieldfield.css keeps this comment. r+sr=me with that fixed.

Comment 6

[Stefan [:stefanh]]

Comment on attachment 398228 [details] [diff] [review]
Move filefield css

No risk, just moving/optimizing css.

Comment 7

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/440becfb57b8 (with comment #5 addressed).

Comment 8

[Robert Kaiser]

Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.