Closed Bug 513891 Opened 10 years ago Closed 10 years ago

Move filefield rules to global/

Categories

(SeaMonkey :: Themes, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: neil, Assigned: stefanh)

References

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file)

Bug 459372 moved the filefield rules to global/ for the Classic theme, however we still have an obsolete copy (assuming we prefer toolkit theming) and we also need to move the rules for the Modern theme into a new filefield.css file.

CCing stefanh to confirm that we want pinstripe filefield theming.
Sure, I'm ok with pinstripe filefield theming.
Actually, I'll lose the opacity rule - but I could add that to the toolkit file. No big deal, I guess.
I used hg copy for modern and since IanN added the filefield code I kept only him as a contributor.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #398228 - Flags: superreview?(neil)
Attachment #398228 - Flags: review?(neil)
Keywords: helpwanted
(In reply to comment #2)
> Actually, I'll lose the opacity rule - but I could add that to the toolkit
> file. No big deal, I guess.

Especially since we don't have any icon on mac - I guess it's because we don't have any shell service for mac.
Attachment #398228 - Flags: superreview?(neil)
Attachment #398228 - Flags: superreview+
Attachment #398228 - Flags: review?(neil)
Attachment #398228 - Flags: review+
Comment on attachment 398228 [details] [diff] [review]
Move filefield css

>-/* File Field Widget */
> filefield {
Nit: the toolkit fieldfield.css keeps this comment. r+sr=me with that fixed.
Comment on attachment 398228 [details] [diff] [review]
Move filefield css

No risk, just moving/optimizing css.
Attachment #398228 - Flags: approval-seamonkey2.0?
Attachment #398228 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
http://hg.mozilla.org/comm-central/rev/440becfb57b8 (with comment #5 addressed).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.
You need to log in before you can comment on or make changes to this bug.