513909 - Make JS build with VC7.1

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[[e-mail]]

...by working around VC7.1's lack of support for varadic macros again.
* In jscntxt.h, define and use LabelMap
* In jsscan.cpp, fallback on getc
* In jstracer.h, define js_LogController
* In nanojit.h, define Nano* macros outside of the namespace
* In nanojit.h, don't include commas in macro arguments

Comment 1

[[e-mail]]

Attachment: Proposed patch

I considered making verbose_arg add the comma i.e.
#define verbose_arg(x) , x
compile(foo, bar, baz verbose_arg(x));
I also wasn't sure whether my changes from DEBUG to JS_JIT_SPEW were correct.

Comment 2

[[e-mail]]

Attachment: Fix compilation of empty functions

It turns out that VC7 can't explicitly construct arrays. This isn't a problem except in one edge case - compiling a completely empty function body (for instance, the body of the "fireActiveItemEvent" in richlistbox.xml). In this case the token stream never gets initialised which confuses the compiler.

Comment 3

[[e-mail]]

Attachment: Don't test debug_only_stmt assertion

Sorry for extra patch... this affects VC7.1 debug only; the value is set in a debug_only_stmt (which is commented out for varadic macro reasons) and JS_ASSERT is compiled out in release builds which is why nobody else hits it.

Comment 4

[Roy Tam]

Attachment: proposed patch

(with cygwin patch of Bug 456924 mixed but it should not affect those not using cygwin build environment, sorry about that.)

Comment 5

[Roy Tam]

Attachment: proposed patch v3

(with cygwin patch of Bug 456924 mixed but it should not affect those not using
cygwin build environment, sorry about that.)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Neil, are you still working on this?

Comment 7

[[e-mail]]

(In reply to Ryan VanderMeulen from comment #6)
> Neil, are you still working on this?

This was only targeted at Gecko 1.9.x anyway.

Comment 8

[Graydon Hoare :graydon]

Comment on attachment 397855 [details] [diff] [review]
Proposed patch

Long dead, clearing out queue.

Comment 9

[Graydon Hoare :graydon]

Comment on attachment 398212 [details] [diff] [review]
Fix compilation of empty functions

Long dead, clearing out queue.

Comment 10

[Graydon Hoare :graydon]

Comment on attachment 398219 [details] [diff] [review]
Don't test debug_only_stmt assertion

Long dead, clearing out queue.