514051 - KB-article waiting-for-review/approval/rejection notifications have malformed links (missing /kb/)

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

The KB-article rejection notifications have malformed links:

https://support-stage.mozilla.org/en/*Cannot+connect+after+upgrading+Firefox

[1] /en/ - shouldn't that be /en-US/?
[2] missing /kb/

So, it should be: https://support-stage.mozilla.org/en-US/kb/*Cannot+connect+after+upgrading+Firefox

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Full email

The email in question

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Meh; here's the RFC/822 -- more better!

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Also, it's not just rejection notifications -- also affects the "waiting for review" notification.

Comment 4

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

Part of this mistake is also the annoying fact that we use en-US even though we have no other en- :) Also, I'm not sure how to get locales from languages in Tiki.

Anyway, this patch should do it.

Comment 5

[Paul Craciunoiu [:paulc]]

r50806 / r50807
To test thoroughly, make sure all three notifications have proper article URLs. Awaiting review + Approved + Not approved

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; haven't tested with other locales, but en-US is fine and dandy.