Closed Bug 514139 Opened 15 years ago Closed 15 years ago

e4x/Regress/regress-319872.js - InternalError: script stack space quota is exhausted

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

(
URL
)

Details

(Keywords: testcase, Whiteboard: fixed-in-tracemonkey) 

http://test.bclary.com/tests/mozilla.org/js/js-test-driver-standards.html?test=e4x/Regress/regress-319872.js;language=type;text/javascript

Expected: InternalError: script stack space quota is exhausted
Actual:   InternalError: allocation size overflow

This doesn't fail on 1.9.2 but does on tracemonkey and mozilla-central. Prior to bug 503952 the test usually failed with a TIMED OUT or terminated without error and failed to report any results.

This may just be a case of changing the test to no expect the stack space quota error. If so, flip to me please.
Flags: in-testsuite+
The "allocation size overflow" error is an expected outcome of an OOM scenario: if the OS keeps dishing out big memory segments, it is possible for the internal "size" integers to overflow before the OS actually returns NULL (especially with the conservative defense against 510319), causing the resulting error to be different.
Igor, same issue with js1_5/extensions/regress-420869-01.js and js1_5/extensions/regress-424683-01.js ? Just make the tests expect either result?
Assignee: general → bclary
Status: NEW → ASSIGNED
http://hg.mozilla.org/tracemonkey/rev/2c3fa422a768
allow InternalError: script stack space quota is exhausted
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
The only question I have is whether it is useful or harmful (confusing, or even an aid to hax0rz? Possibly if they can probe for an off-by-small bug where we fail to detect overflow) to have two errors here, one talking about size overflow.

Would life be better all around if we just said "script stack space quota is exhausted" or is that misleading in a way users could detect?

/be
Whiteboard: fixed-in-tracemonkey
reopening since this is not yet on mc.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/mozilla-central/rev/2c3fa422a768
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.