514179 - embedded editor web workers require javascript in /js/bespin

Status: RESOLVED FIXED

(Skywriter Graveyard :: Editor, defect)

Description

[Alex Iskander]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6; en-us) AppleWebKit/531.9 (KHTML, like Gecko) Version/4.0.3 Safari/531.9
Build Identifier: 

Web workers depend on bespin’s JavaScript being in a particular location: “/js/bespin/“

Reproducible: Always

Steps to Reproduce:
1. Set up a web environment with Bespin’s JavaScript at some directory other than /js/ (for instance, /app/js/)

2. Embed the Bespin editor in a page (for instance, /app/index.html). You could likely use frontend/tests/manual/editor/singleeditor.html to test it.

3. Attempt to run the app.
Actual Results:  
The app will likely crash, because the web workers will not work, and are referenced by parser.js and codecompletion.js.

Expected Results:  
The web workers should work by using a path relative to the rest of bespin.

I think that this can be solved by using dojo.moduleUrl. I have not yet tried it. 

I have a partial patch that simply changes the attempt at using /js/bespin/bootstrap_worker.js to reference the constant JS_WORKER_SOURCE. While not complete, it would make the above test case work, since JS_WORKER_SOURCE uses a relative path (then you’d only need to have a js/bespin directory in the same directory as your index.html).

I’m willing to work on a more complete patch.

Comment 1

[Alex Iskander]

Attachment: Partial patch

This patch also addresses several other bugs which I am in the process of submitting.

Comment 2

[Alex Iskander]

Fixed in http://hg.mozilla.org/labs/bespin/rev/272aa02709a1