514220 - No feedback when user taps on "See all bookmarks"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Madhava Enros [:madhava]]

When the user taps on "See all bookmarks" in the awesomebar list, there's no instant feedback.  When you have only a small set of bookmarks, you do get some feedback in that the bookmark list comes up relatively quickly.  When you have a large set, though, like one synced through Weave, it takes a number of seconds for the bookmark list to come up (this should probably be another bug).

Some solutions:
1. Make the bookmark list come up immediately.  This doesn't mean that the whole list of bookmarks has to be be loaded immediately -- the bookmark list could come up with just the first 5 or so bookmarks (as many as the user can see) and the rest could be loaded in the background, progressively.
2. Provide some "in place" indication that the tap registered.  For example, we could replace the ">" at the right-hand side of the row with a spinning throbber.

Even if 1 is done, 2 may be necessary given that it's unlikely to be instantaneous.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

same issue as bug 511275

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> same issue as bug 511275

not quite, actually. the handler for the bookmarks item uses a different code path.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

variant of the patch for bug 511275

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 399644 [details] [diff] [review]
patch

Can you file a bug and reference it in the comments?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/ec83f38e63ff

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED (fennec <3 highlighting) on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090915 Fennec/1.0a3

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090915
Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090915
Fennec/1.0b4pre

Comment 7

[Madhava Enros [:madhava]]

We get row-highlighting immediately now, which is helpful, but it still takes a number of seconds to bring up the bookmarks list when you have a lot of bookmarks (as you do after a weave sync with your desktop set).  I think that we need something more than just immediate row-highlighting to give the user a sense that something is actually happening.  There was an idea in the original bug summary to replace the > indicator with a throbber when we're waiting for the list to come up.

Also - is there any way to speed up bringing up the list?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Filed bug 521116 for that - tracking multiple patches in one bug is no fun.

Comment 9

[Aakash Desai [:aakashd]]

We have a testcase for this, but it needs to include this on the expected results.

Comment 10

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=7640 regression tests this bug.